Skip to content

Log all output to a log file#78

Merged
amstewart merged 6 commits intoni:masterfrom
texasaggie97:dev/texasaggie97/log-progress
Nov 13, 2025
Merged

Log all output to a log file#78
amstewart merged 6 commits intoni:masterfrom
texasaggie97:dev/texasaggie97/log-progress

Conversation

@texasaggie97
Copy link
Copy Markdown
Collaborator

@texasaggie97 texasaggie97 commented Oct 17, 2025

Summary of Changes

  • Capture and log all output to a log file for later validation
  • Fixed some instances of --dry-run not working and causing errors
  • Use pathlib.Path for consistency and cleanliness
  • Include changes from Source setup-venv.yml from Tools repository #80 - Needed for tests to run

Justification

AB#3252591
AB#3433829

Testing

Manually checked with and without --dry-run for both configure and verify

Procedure

  • This PR: changes user-visible behavior, fixes a bug, or impacts the project's security profile; and so it includes a CHANGELOG note.
  • I certify that the contents of this pull request complies with the Developer Certificate of Origin.

Copy link
Copy Markdown
Contributor

@dmondrik dmondrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have specific concerns for which I'd need to re-review anything. I just want to know the outcome.

@texasaggie97 texasaggie97 force-pushed the dev/texasaggie97/log-progress branch from b272d50 to 0b95f79 Compare October 17, 2025 22:04
@texasaggie97 texasaggie97 force-pushed the dev/texasaggie97/log-progress branch from 0b95f79 to b722096 Compare October 21, 2025 21:49
@texasaggie97 texasaggie97 force-pushed the dev/texasaggie97/log-progress branch from b722096 to 65fb175 Compare November 12, 2025 15:57
Signed-off-by: Mark Silva <mark.silva@emerson.com>
Signed-off-by: Mark Silva <mark.silva@emerson.com>
Signed-off-by: Mark Silva <mark.silva@emerson.com>
Signed-off-by: Mark Silva <mark.silva@emerson.com>
Signed-off-by: Mark Silva <mark.silva@emerson.com>
@texasaggie97 texasaggie97 force-pushed the dev/texasaggie97/log-progress branch from 2696466 to 3cb0f80 Compare November 12, 2025 16:12
Signed-off-by: Mark Silva <mark.silva@emerson.com>
@amstewart amstewart merged commit 9b823f2 into ni:master Nov 13, 2025
5 checks passed
@texasaggie97 texasaggie97 deleted the dev/texasaggie97/log-progress branch November 13, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants