Skip to content

Source setup-venv.yml from Tools repository#80

Closed
tkrebes wants to merge 1 commit intoni:masterfrom
tkrebes:tkrebes-patch-1
Closed

Source setup-venv.yml from Tools repository#80
tkrebes wants to merge 1 commit intoni:masterfrom
tkrebes:tkrebes-patch-1

Conversation

@tkrebes
Copy link
Copy Markdown
Contributor

@tkrebes tkrebes commented Oct 28, 2025

Summary of Changes

Sourced setup-venv.yml from Tools repository

Justification

setup-venv.yml will soon require setup-venv.ps1. This change uses a version of setup-venv.yml that does not require setup-venv.ps1.

Testing

Ran azure devops pipeline

Procedure

  • This PR: changes user-visible behavior, fixes a bug, or impacts the project's security profile; and so it includes a CHANGELOG note.
  • I certify that the contents of this pull request complies with the Developer Certificate of Origin.

@tkrebes tkrebes requested review from a team, AlexHearnNI and amstewart as code owners October 28, 2025 18:28
@tkrebes tkrebes force-pushed the tkrebes-patch-1 branch 4 times, most recently from 65ca98d to 440a4e2 Compare October 28, 2025 20:51
Signed-off-by: Tyler Krehbiel <39509337+tkrebes@users.noreply.github.com>
@tkrebes tkrebes changed the title Add checkout_shared_repo template to SanityTests job Source setup-venv.yml from Tools repository Nov 5, 2025
- repository: Tools
type: git
name: DevCentral/Tools
ref: 1034f8129f933c91c24abbd737e429590e3f23ff
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty concerned that this will break at some point in the future. Please put a comment here, explaining that we're using an old version of setup-venv.yml.

Suggested change
ref: 1034f8129f933c91c24abbd737e429590e3f23ff
# Use an old version of setup-venv.yml
ref: 1034f8129f933c91c24abbd737e429590e3f23ff

@texasaggie97 texasaggie97 mentioned this pull request Nov 12, 2025
2 tasks
@amstewart
Copy link
Copy Markdown
Collaborator

@tkrebes Is this PR still necessary, after merging #78 ?

@tkrebes tkrebes closed this Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants