Fixed termbox2 demo build, added scroll functionality #523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the demo
Added horizontal scroll functionality
The termbox2 renderer and the demo supported scroll functionality previously, but they were never shown in the demo. I added horizontal scrolling for the user to be able to see the rest of the palette test window through
.clipexactly as it is done in the documentation.Things that will stay "broken"
Due to how string slices are rendered, horizontal scrolling will trim the string in the wrong direction. It seems that the only way to mitigate this without touching the renderer is to compute strings with the proper trimmed length, but computed strings would require allocating them outside of the layout build. Implementation of this would bloat the demo code, so I kept this out.