Skip to content

Conversation

@Godje
Copy link
Contributor

@Godje Godje commented Oct 3, 2025

note to Maintainer

This branch includes the code from PR #523 . If this merges first, the other #523 can be closed.

Bug (before)

Incorrect trimming behavior appears when the text's boundingBox.x coordinate starts going below negative numbers. Instead of culling the text from the left, it trims it from the right.

Visual demonstration of the bug

Before scrolling

image

After scrolling

image

Fix (after)

Added a small loop before the main text rendering loop that increments the "text printed counter" (i) without actually printing the text, which then makes the main renderer loop start from the correct character when printing.

Visual demonstration of the fix

Before scrolling

image

After scrolling

image

@nicbarker
Copy link
Owner

Thanks for the great work here!

@nicbarker nicbarker merged commit fd97d81 into nicbarker:main Oct 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants