[Renderers/termbox] fixed horizontal text culling bug #525
+27
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note to Maintainer
This branch includes the code from PR #523 . If this merges first, the other #523 can be closed.
Bug (before)
Incorrect trimming behavior appears when the text's
boundingBox.xcoordinate starts going below negative numbers. Instead of culling the text from the left, it trims it from the right.Visual demonstration of the bug
Before scrolling
After scrolling
Fix (after)
Added a small loop before the main text rendering loop that increments the "text printed counter" (
i) without actually printing the text, which then makes the main renderer loop start from the correct character when printing.Visual demonstration of the fix
Before scrolling
After scrolling