Fixed the OpenAPS pill and forecast lines from not showing#8324
Open
yodax wants to merge 2 commits intonightscout:devfrom
Open
Fixed the OpenAPS pill and forecast lines from not showing#8324yodax wants to merge 2 commits intonightscout:devfrom
yodax wants to merge 2 commits intonightscout:devfrom
Conversation
…ected data is present in lastEnacted
Member
|
Very very nice! 🎉 |
|
Would be nice if this fix was merged! |
Contributor
Author
|
It’s been more than a year since the opening of the PR; a release was just made, the PR not included. I still see people complaining about this not working for them. The fix works and has tests associated with it. (I have been running the code for all that time without a single forecast line disappearing) If there’s no intention to release it, I’m ok with that of course. I would suggest closing the PR. |
Member
|
Thank you for this important bug fix. It will be processed soon. Fwiw, we have asked for review and help on database upgrade going on three years and so can understand your frustration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my local NS on the left and on the right is current main running on the same database.
Every so often the OpenAPS pill would stop updating and the forecast lines would disappear. I created a test to reproduce this using the data from my mongo database. This allowed me to narrow it down to the fix below. The lastEnacted field didn't always have a "rate" field set in each of these json objects.