.NET 9 code quality fixes #682
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this would make it clearer for end-users, and avoid adding noise in the build process
...conflicting with keyword Enum
fix "Remove unused parameter"
we might use them later on
…ha20 implementation
fix IDE0058
It's hell break loose time
Contributor
Author
|
Superseded by #687 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address code quality checks introduced in .NET 9. Easiest one like "name/collection initialization can be simplified" are fixed automatically with Visual Studio.
Todo
Level: easy
System.Exceptionis not sufficiently specific (commitf084711)<AnalysisMode>Recommended</AnalysisMode>Sodium.Core[require testing with real ChaCha20 stream, but it's rare]Level: medium
<AnalysisMode>Recommended</AnalysisMode>