-
-
Notifications
You must be signed in to change notification settings - Fork 743
.NET 9 code quality fixes #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
voldemort2826
wants to merge
99
commits into
nilaoda:main
Choose a base branch
from
voldemort2826:code-quality
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this would make it clearer for end-users, and avoid adding noise in the build process
...conflicting with keyword Enum
fix "Remove unused parameter"
we might use them later on
…ha20 implementation
fix IDE0058
It's hell break loose time
6 tasks
d1bea34 to
e53faf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen for #682 due to branch name change
Address code quality checks introduced in .NET 9. Easiest one like "name/collection initialization can be simplified" are fixed automatically with Visual Studio.
Todo
Level: easy
System.Exceptionis not sufficiently specific (commitf084711)<AnalysisMode>Recommended</AnalysisMode>Sodium.Core[require testing with real ChaCha20 stream, but it's rare]Level: medium
<AnalysisMode>Recommended</AnalysisMode>