Improvements towards supporting big packages (nwaku) #1532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PackageNotFoundError exception type in common.nim - Use PackageNotFoundError in download.nim when package is not found - Catch PackageNotFoundError instead of CatchableError in nimblesat.nim validation to only skip versions for truly missing packages
Some packages use 'v' prefixed tags (e.g., v0.1.0) while the version in nimble is without prefix (0.1.0). When checkout fails, try again with 'v' prefix as fallback.
Add specialized addUnique for PackageMinimalInfo that compares by name and version only. This ensures when multiple nimble file revisions exist for the same version tag, we keep the first one. Change processing order in getPackageMinimalVersionsFromRepo and getPackageMinimalVersionsFromRepoAsync to: 1. Process tagged versions first (added to result) 2. Add HEAD version last using addUnique This ensures tagged releases take precedence over HEAD when both have the same version, providing more reliable package metadata.
(old pkgs may trigger potential errors)
version discovery option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.