Skip to content

[WIP][MAINT] bump pre-commit hooks versions#1467

Draft
Remi-Gau wants to merge 1 commit intonipy:masterfrom
Remi-Gau:maint/pre-commit-update
Draft

[WIP][MAINT] bump pre-commit hooks versions#1467
Remi-Gau wants to merge 1 commit intonipy:masterfrom
Remi-Gau:maint/pre-commit-update

Conversation

@Remi-Gau
Copy link
Contributor

  • WIP PR
  • bumping hooks to see what fails and to discuss what can be auto-fixed, ignored...

@Remi-Gau
Copy link
Contributor Author

Things seems to be fine locally but I am getting a bunch of errors when running pre-commit locally:

Found 237 errors.
No fixes available (182 hidden fixes can be enabled with the `--unsafe-fixes` option).
``

@Remi-Gau
Copy link
Contributor Author

note that when running style with tox we do get mention of some (153 fixes available with --unsafe-fixes).

tox run -e style
ROOT: will run in automatically provisioned tox, host /home/remi-gau/github/nibabel/.venv/bin/python3 is missing [requires (has)]: tox-uv
ROOT: install_deps> python -I -m pip install tox tox-uv 'tox>=4'
ROOT: provision> .tox/.tox/bin/python -m tox --colored yes run -e style
style: venv> .tox/.tox/bin/uv venv -p /home/remi-gau/github/nibabel/.tox/.tox/bin/python --allow-existing '--prompt=nibabel[style]' --python-preference system /home/remi-gau/github/nibabel/.tox/style
style: uv-sync> .tox/.tox/bin/uv sync --locked --python-preference system --extra dicomfs --extra indexed-gzip --extra test --extra zstd --no-default-groups --group style -p /home/remi-gau/github/nibabel/.tox/.tox/bin/python
style: commands[0]> ruff check --diff nibabel
No errors would be fixed (153 fixes available with `--unsafe-fixes`).
style: commands[1]> ruff format --diff nibabel
224 files already formatted
  style: OK (21.09=setup[21.00]+cmd[0.05,0.04] seconds)
  congratulations :) (21.22 seconds)

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.42%. Comparing base (673962f) to head (98a7607).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1467   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files         209      209           
  Lines       29822    29822           
  Branches     4483     4483           
=======================================
  Hits        28457    28457           
  Misses        930      930           
  Partials      435      435           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant