-
-
Notifications
You must be signed in to change notification settings - Fork 300
yazi: update theming for v25.12.29 #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
trueNAHO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to add yourself as a module maintainer because this module is currently unmaintained:
Line 4 in 2b727da
| maintainers = [ ]; |
You can do this as a separate commit or just open a dedicated PR for this, which is probably easier.
| roundedIndicator = lib.mkOption { | ||
| description = "Whether to use rounded corners font on selection indicator."; | ||
| type = lib.types.bool; | ||
| default = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Changes have been tested locally
- Changes have been tested in testbeds
When disabling the roundedIndicator option with
diff --git a/modules/yazi/hm.nix b/modules/yazi/hm.nix
index 0911bc7f..a14439e8 100644
--- a/modules/yazi/hm.nix
+++ b/modules/yazi/hm.nix
@@ -11,7 +11,7 @@ mkTarget {
roundedIndicator = lib.mkOption {
description = "Whether to use rounded corners font on selection indicator.";
type = lib.types.bool;
- default = true;
+ default = false;
};
};
the nix run .#testbed:yazi:dark testbed shows the following error:
Terminal response timeout: The request sent by Yazi didn't receive a correct response.
Please check your terminal environment as per: https:yazi-rs.github.io/docs/faq#trt
This error does not occur when the roundedIndicator is enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the error in the testbed regardless of if roundedIndicator is enabled, however, the error goes in both cases when I run yazi in a new terminal.
https://yazi-rs.github.io/docs/faq#trt seems to suggest that this is usually related to tmux, could this be related to how pkgs.makeAutostartItem launches it in the testbed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like launching yazi througn its .desktop entry in the testbed causes the error, will try and investigate further.
modules/yazi/hm.nix
Outdated
| open = "█"; | ||
| close = "█"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure these are the correct characters? My fonts are unable to render them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied them directly from sxyazi/yazi#3419 (comment). They also render correctly in the testbed.
Moved indicator config into new section. Added option to toggle new rounded corners on indicator Updated directory theming rule as folders no longer have mime type inode/directory
fd8cec1 to
801e242
Compare
Updates configuration for yazi v25.12.29 (this version is already in nixpkgs-unstable).
Fixes #2121.
Directories are now classified as
folder/*however this doesn't seem to get checked until the parent directory is navigated into which leaves the directories in columns that haven't been navigated to in the default white formatting. Using the*/url specifier instead of mime types fixes this.