docs: add guide and skill for adding new agent support#959
docs: add guide and skill for adding new agent support#959njbrake merged 3 commits intonjbrake:mainfrom
Conversation
- docs/development/adding-agents.md: comprehensive reference covering levels of support, step-by-step instructions, hook format reference, and common pitfalls - .claude/skills/add-agent/SKILL.md: interactive skill that walks through the agent addition workflow with verification checkpoints; includes a self-update section so the skill stays current - .kiro/skills/add-agent -> symlink to .claude/skills/add-agent so the skill works for both Claude Code and Kiro CLI users
Add pitfalls discovered during njbrake#958 review: - Sandbox hooks need separate wiring in build_container_config - Keep install_*_hooks() as pure file IO (no subprocess calls) - Use --format json when parsing agent CLIs - Document missing Waiting status as a limitation
|
Note: this comment was drafted by Claude via back-and-forth with @njbrake. The reasoning and decisions are his; the prose is Claude's. Thanks @nycjay! The doc is great, and folding the #958 review lessons into a follow-up commit was a nice touch. I'd like to land the doc with a few small fixups, but hold off on the skill files for this PR. Details below. Doc: ready to merge after these fixes
Skill: holding off for this PRI'd like to punt on
Could you drop those two files from this PR and we'll land just the doc? Skill content isn't lost; it's preserved in the PR history if I decide later that AoE wants committed skills. Thanks again for both this PR and #958, and especially for the pitfalls section that bakes review lessons back into the docs. That's exactly the right pattern. |
|
Makes perfect sense - I'll make those changes shortly. On our internal repos, we've been adding more agent skills for content like this, but I get that it's a change in precendent. |
- Remove .claude/skills/ and .kiro/skills/ (skill precedent decision deferred per maintainer) - Add website sync entries (PAGES, URL_MAP in sync-docs.mjs, nav in docsNav.ts) - Add cross-link from AGENTS.md to docs/development/adding-agents.md
Description
Adds documentation and a Kiro skill to make adding new agent support easier for contributors.
Motivated by the experience of adding Kiro CLI support (#958), where the process required significant discovery across multiple files with no centralized guide.
PR Type
Checklist
AI Usage
AI Model/Tool used:
Claude Sonnet 4 via Kiro CLI
Any Additional AI Details you'd like to share:
Written based on the actual experience of implementing Kiro CLI agent support in #958.
NOTE:
When responding to reviewer questions, please respond yourself rather than copy/pasting reviewer comments into an AI and pasting back its answer. We want to discuss with you, not your AI :)