[Wait for #2963] Meson run command check #2964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baek2sm
approved these changes
Feb 27, 2025
jijoongmoon
changed the title
piotrrak
force-pushed
the
meson_run_command_check
branch
from
2f614b6 to
df26d50
Compare
piotrrak
requested review from
DonghakPark,
EunjuYang,
SeoHyungjun,
again4you,
anyj0527,
djeong20,
dkjung,
gichan-jang,
haehun,
jaeyun-jung,
jihochu,
leemgs,
lhs8928,
myungjoo,
skykongkong8,
songgot and
wooksong
as code owners
|
Updated with regards to windows/nproc changes. |
|
Invalid command that was exposed by this change is: Ubuntu: Windows: |
piotrrak
force-pushed
the
meson_run_command_check
branch
from
df26d50 to
e75c9a7
Compare
piotrrak
force-pushed
the
meson_run_command_check
branch
from
e75c9a7 to
dd940e1
Compare
|
Android failure: ...
Run-time dependency capi-ml-common found: NO (tried pkgconfig and cmake)
Message: preparing blas
meson.build:313:4: ERROR: Include dir openblas/include does not exist.
A full log can be found at /home/runner/work/nntrainer/nntrainer/builddir/meson-logs/meson-log.txt
Error: Process completed with exit code 1.Honestly no idea |
This change removes copy run_command that was always failing without us noticing. This was part of change 931c586 "[Application] Add Mixed Precision Application" Path Application/MixedPrecision/res has never existed. Signed-off-by: Piotr Rak <[email protected]>
Since result.status() is rarely tested one should always specify it. This also fixes meson warning. Signed-off-by: Piotr Rak <[email protected]>
piotrrak
force-pushed
the
meson_run_command_check
branch
from
dd940e1 to
03c879f
Compare
gkisalapl
approved these changes
Mar 12, 2025
|
@jijoongmoon Hi, rebase is not required for this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up meson warning:
WARNING: You should add the boolean check kwarg to the run_command call.
It currently defaults to false,
but it will default to true in meson 2.0.
See also: mesonbuild/meson#9300
Self evaluation:
How to evaluate:
N/A