[meson] Remove bogus resource copy command #2999
Conversation
This change removes copy run_command that was always failing without us noticing. This was part of change 931c586 "[Application] Add Mixed Precision Application" Path Application/MixedPrecision/res has never existed. Signed-off-by: Piotr Rak <[email protected]>
piotrrak
requested review from
DonghakPark,
EunjuYang,
SeoHyungjun,
again4you,
anyj0527,
baek2sm,
djeong20,
dkjung,
gichan-jang,
haehun,
jaeyun-jung,
jihochu,
jijoongmoon,
leemgs,
lhs8928,
myungjoo,
skykongkong8,
songgot and
wooksong
as code owners
|
@DonghakPark Just FYI: you might want to to take a look at this change, maybe those resource files were added to the other place or were forgotten to be added. Here is reference to the change where this command was added 931c586 |
There was a problem hiding this comment.
Nice catch! It seems like 'res' under contains xx.ini files.
@DonghakPark Could you confirm that the res directory is not required for this application?
There was a problem hiding this comment.
Nice Catch, It's my mistake. Thank you for Detail work!!
As @djeong20 mentioned while working by copying the folder of another application, the method used by the other application remained the same.
MixedPrecision Application directly defines the model, there is no ```ini file`` and it is not necessary.
9 participants
This change removes copy run_command that was always failing without us noticing. This was part of change 931c586
"[Application] Add Mixed Precision Application"
Path Application/MixedPrecision/res has never existed.
This change partly addresses build failure in #2964 on Ubuntu
Self evaluation: