add verbose to identify the flaky cases #55481
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
Assert.ok takes a message parameter, that's probably cleaner |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55481 +/- ##
==========================================
+ Coverage 88.41% 88.42% +0.01%
==========================================
Files 653 653
Lines 187415 187421 +6
Branches 36074 36066 -8
==========================================
+ Hits 165698 165731 +33
+ Misses 14965 14943 -22
+ Partials 6752 6747 -5 |
Thanks. Looks good now. |
avivkeller
reviewed
Oct 21, 2024
BridgeAR
approved these changes
Oct 28, 2024
github-actions
bot
removed
the
request-ci
jasnell
reviewed
Nov 5, 2024
| @@ -10,7 +10,9 @@ const ALLOWED_MARGIN = 10; | |||
| const expected = ['Start to Now', 'A to Now', 'A to B']; | |||
| const obs = new PerformanceObserver(common.mustCall((items) => { | |||
| items.getEntries().forEach(({ name, duration }) => { | |||
| assert.ok(duration > (DELAY - ALLOWED_MARGIN)); | |||
| // TODO(mrjithil) remove after 55431 fixed | |||
There was a problem hiding this comment.
Nit: it would be more helpful for the 55431 to provide a complete URL. It would also be helpful to expand a bit with a quick summary of what that issue is.
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logs for fixing the 55431 flaky test.