Skip to content

add verbose to identify the flaky cases #55481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add verbose to identify the flaky cases #55481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/parallel/test-performance-measure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ const ALLOWED_MARGIN = 10;
const expected = ['Start to Now', 'A to Now', 'A to B'];
const obs = new PerformanceObserver(common.mustCall((items) => {
items.getEntries().forEach(({ name, duration }) => {
assert.ok(duration > (DELAY - ALLOWED_MARGIN));
// TODO(mrjithil) remove after 55431 fixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it would be more helpful for the 55431 to provide a complete URL. It would also be helpful to expand a bit with a quick summary of what that issue is.

const msg = `${DELAY} | ${ALLOWED_MARGIN} | ${duration}`;
assert.ok(duration > (DELAY - ALLOWED_MARGIN), msg);
assert.strictEqual(expected.shift(), name);
});
}));
Expand Down
Loading