-
Notifications
You must be signed in to change notification settings - Fork 650
NIP-47 Add Hold Invoice Support #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frnandu
wants to merge
8
commits into
nostr-protocol:master
Choose a base branch
from
frnandu:nip-47-hold-invoices
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Semisol
suggested changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see review
Semisol
reviewed
May 7, 2025
rolznz
reviewed
May 8, 2025
Implemented in Alby JS SDK: getAlby/js-sdk#382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
This PR introduces support for hold invoices in the Nostr Wallet Connect (NIP-47) protocol.
Hold invoices enable more advanced payment workflows where the receiver must explicitly settle or cancel the invoice using the preimage. This allows for enhanced control and coordination in payment flows, such as conditional payments or escrow-like behavior.
Summary of Changes:
New RPC methods:
make_hold_invoice
: Create a hold invoice using a pre-generated preimage and its payment hash.settle_hold_invoice
: Settle a hold invoice by providing the original preimage.cancel_hold_invoice
: Cancel a hold invoice using its payment hash.New notification:
hold_invoice_accepted
: Emitted when a payer accepts a hold invoice (i.e., locks in payment).Extended example flow: A new section documents the end-to-end process for using hold invoices, including invoice creation, settlement, and cancellation.
Motivation:
Hold invoices are a key feature in Lightning-based applications that require more complex transaction logic, such as:
This addition expands the versatility and usability of NWC while maintaining backward compatibility with existing methods.
Implementations and usages: