feat: add hold invoices support for LND & LDK #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

frnandu wants to merge 28 commits into master from feat/hold-invoices

+1,673 −25

Contributor

frnandu commented May 6, 2025 •

edited

Loading

fixes #1295

NWC new methods
new hold_invoice_accepted notification
LND implementation
LDK implementation
handle self-payments
Add hold invoice support to JS SDK (@rolznz to do) -> feat: add hold invoice NWC methods and notification type js-sdk#382
Draft NIP-47 spec PR -> NIP-47 Add Hold Invoice Support nostr-protocol/nips#1913

frnandu added 2 commits

May 6, 2025 14:34


          feat: add LND hold invoices support

5e00db3


          fix: add HOLD_INVOICE_ACCEPTED_NOTIFICATION to notifications list ret…

1f37ce7

…urned by get_info

rolznz reviewed

View reviewed changes

constants/constants.go Show resolved Hide resolved

rolznz reviewed

View reviewed changes

lnclient/lnd/lnd.go Show resolved Hide resolved


          fix: revert

47308d5

rolznz reviewed

View reviewed changes

nip47/controllers/cancel_hold_invoice_controller.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

nip47/controllers/cancel_hold_invoice_controller_test.go Outdated Show resolved Hide resolved


          fix: remove unneeded null checks

6395c41

rolznz reviewed

View reviewed changes

nip47/controllers/make_hold_invoice_controller.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

nip47/controllers/make_hold_invoice_controller.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

nip47/controllers/make_hold_invoice_controller_test.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

nip47/controllers/settle_hold_invoice_controller_test.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

transactions/transactions_service.go Show resolved Hide resolved


          docs: add extra event type to README

764d497

rolznz reviewed

View reviewed changes

constants/constants.go Show resolved Hide resolved

rolznz reviewed

View reviewed changes

transactions/transactions_service.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

transactions/transactions_service.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

nip47/controllers/settle_hold_invoice_controller.go Show resolved Hide resolved

rolznz reviewed

View reviewed changes

transactions/transactions_service.go Show resolved Hide resolved

rolznz reviewed

View reviewed changes

transactions/transactions_service.go

+              		}
+              		var err error
+              		settledTransaction, err = svc.markTransactionSettled(tx, &dbTransaction, preimage, 0, false) // Assuming not self-payment for now

Contributor

rolznz May 6, 2025

hmm, self-payments are a problem. I'll add this to the PR TODO list

Contributor Author

frnandu May 8, 2025

Do you see a quick way to handle this?

rolznz reviewed

View reviewed changes

transactions/transactions_service.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

transactions/transactions_service.go Show resolved Hide resolved

frnandu and others added 5 commits

May 6, 2025 17:57


          feat: add LND hold invoices support

e1cefb9


          fix: add HOLD_INVOICE_ACCEPTED_NOTIFICATION to notifications list ret…

2d51cfb

…urned by get_info


          fix: revert

c9ac1cf


          fix: remove unneeded null checks

7772ab1


          docs: add extra event type to README

92b8008

frnandu mentioned this pull request

add hold invoice support relaystr/ndk#147

Open

frnandu added 2 commits

May 6, 2025 18:58


          Merge remote-tracking branch 'origin/feat/hold-invoices' into feat/ho…

3ad5a18

…ld-invoices


          fix: remove 0 expiry checking in the make_hold_invoice_controller

f754de4

frnandu added 15 commits

May 7, 2025 14:56


          fix: use JSON logging

5180ede


          revert fly.toml

16207ec


          fix: duplicated check

1ea6ef6


          fix: move publishing nwc_hold_invoice_accepted out of the transaction

92b6433


          fix: move publishing nwc_hold_invoice_accepted out of the transaction

5f3cc17


          fix: check the invoice state ACCEPTED before calling the lnClient.Set…

a3caf37

…tleHoldInvoice


          fix: check the invoice state ACCEPTED before calling the lnClient.Set…

0a59793

…tleHoldInvoice


          fix: check the invoice state ACCEPTED before calling the lnClient.Set…

4fce7fb

…tleHoldInvoice


          fix: check the invoice state ACCEPTED before calling the lnClient.Set…

36fee98

…tleHoldInvoice


          fix: cancel hold invoice tests

0360dc5


          fix: make hold invoice tests

f56f9a4


          fix: make hold invoice tests

589ce25


          fix: settle hold invoice tests

228901f


          fix: resubscribe to pending hold invoices

d0b4836


          fix: missing WatchHoldInvoice

bc252ec

 in the mocks

frnandu mentioned this pull request

NIP-47 Add Hold Invoice Support nostr-protocol/nips#1913

Open

rolznz added this to the v1.18.0 milestone

Contributor

rolznz commented May 8, 2025

Linking #1212 as I think this is an example where we need to make sure the notification is sent to the relay.


          feat: add LDK impl

2555f89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet