samples: matter: Fix image-scoped shield variable names - #32
Merged
kkasperczyk-no merged 1 commit intoAug 13, 2026
Merged
Conversation
Sysbuild derives the main image name from the application directory. The bridge and weather station docs and test scenarios still used matter_bridge_SHIELD and matter_weather_station_SHIELD, which match no image, so CONFIG_SHIELD and CONFIG_CHIP_WIFI stayed disabled on Wi-Fi builds. Rename to bridge_SHIELD and weather_station_SHIELD, and fix the internal-memory doc example to use the directory name "bridge". Signed-off-by: Michał Szablowski <michal.szablowski@nordicsemi.no>
doublemis1
force-pushed
the
fix/matter-shield-image-prefix
branch
from
August 12, 2026 14:55
adef7fe to
486f6ab
Compare
|
You can find the documentation preview for this PR here. |
peknis
approved these changes
Aug 13, 2026
kkasperczyk-no
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sysbuild derives the main image name from the application directory. The bridge and weather station docs and test scenarios still used matter_bridge_SHIELD and matter_weather_station_SHIELD, which match no image, so CONFIG_SHIELD and CONFIG_CHIP_WIFI stayed disabled on Wi-Fi builds.
Rename to bridge_SHIELD and weather_station_SHIELD, and fix the internal-memory doc example to use the directory name "bridge".