app: Don't start PPP without a request#28
Merged
Conversation
trantanen
force-pushed
the
ppp_no_auto
branch
from
8d71de7 to
03228c2
Compare
trantanen
force-pushed
the
ppp_no_auto
branch
from
03228c2 to
0baf554
Compare
MarkusLassila
approved these changes
Oct 17, 2025
trantanen
force-pushed
the
ppp_no_auto
branch
from
9de96a0 to
e49fae1
Compare
Contributor
|
Before properly reviewing this: Can we instead get rid of It would be a step towards standard. As an example: https://onomondo.com/blog/at-commands-guide-for-iot-devices/ |
SeppoTakalo
approved these changes
Oct 17, 2025
Contributor
SeppoTakalo
left a comment
SeppoTakalo
left a comment
There was a problem hiding this comment.
Good to go in.
I think the ATD proposal can be followed up later.
divipillai
reviewed
Oct 17, 2025
trantanen
force-pushed
the
ppp_no_auto
branch
from
7b16de9 to
17c6669
Compare
divipillai
approved these changes
Oct 17, 2025
trantanen
force-pushed
the
ppp_no_auto
branch
from
17c6669 to
caf9d8a
Compare
PPP connection has been opened automatically when AT+CFUN=1 is done and PDN has been activated even without PPP request using AT#XPPP=1. This is now changed so you need to issue AT#XPPP=1 in order to start PPP. This can be done before or after AT+CFUN=1. Enabled CONFIG_MODEM_BACKEND_UART_ASYNC_HWFC forgotten in PR #6. Jira: SLM-85 Signed-off-by: Tommi Rantanen <tommi.rantanen@nordicsemi.no>
trantanen
force-pushed
the
ppp_no_auto
branch
from
caf9d8a to
3a3dc3b
Compare
trantanen
commented
Oct 22, 2025
MarkusLassila
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PPP connection has been opened automatically when
AT+CFUN=1is done and PDN has been activated even without PPP request usingAT#XPPP=1. This is now changed so you need to issueAT#XPPP=1in order to start PPP. This can be done before or afterAT+CFUN=1.Enabled CONFIG_MODEM_BACKEND_UART_ASYNC_HWFC forgotten in PR #6.
Jira: SLM-85