app: PIPE interface to UART#6
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a PIPE interface to the Serial Modem UART to enable unified UART implementation for both pure AT-commands and CMUXed AT-commands with PPP. The changes streamline the UART backend architecture by consolidating functionality and removing the SLM-specific backend dependency.
- Replaces backend-specific UART implementations with a unified pipe interface
- Refactors AT command processing to support CMUX switching with proper state management
- Standardizes error message formatting across initialization functions
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| doc/app/sm_description.rst | Updates documentation for PPP configuration files |
| app/src/sm_uart_handler.h | Adds pipe interface declarations and transmit callback typedef |
| app/src/sm_uart_handler.c | Implements unified UART pipe interface with CMUX support |
| app/src/sm_ppp.c | Switches from SLM-specific to generic UART backend |
| app/src/sm_defines.h | Adds CMUX command return code constant |
| app/src/sm_cmux.h | Adds uninit function declaration |
| app/src/sm_cmux.c | Refactors CMUX to use new pipe interface and removes SLM dependency |
| app/src/sm_at_host.h | Updates AT receive function signature |
| app/src/sm_at_host.c | Removes backend abstraction and integrates direct UART calls |
| app/src/sm_at_commands.c | Standardizes error message formatting |
| app/overlay-ppp.conf | Removes SLM backend configuration |
| app/overlay-ppp-without-cmux.conf | Adds generic UART backend configuration |
| app/overlay-ppp-cmux-linux.conf | Updates buffer sizing and removes SLM configuration |
| app/overlay-cmux.conf | Removes SLM backend and buffer configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
57ea18f to
6de676d
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
6de676d to
ed3860e
Compare
d729f8a to
a564d42
Compare
trantanen
left a comment
There was a problem hiding this comment.
Add Jira: SLM-xx into PR description.
|
@moksanen, @jvaliharju |
5c31b71 to
a8ddf7c
Compare
Jira: SLM-134 Implement PIPE interface to Serial Modem UART to be able to use the same UART implementation for both pure AT-commands and for CMUXed AT-commands and PPP. Signed-off-by: Markus Lassila <markus.lassila@nordicsemi.no>
a8ddf7c to
c262cab
Compare
PPP connection has been opened automatically when AT+CFUN=1 is done and PDN has been activated even without PPP request using AT#XPPP=1. This is now changed so you need to issue AT#XPPP=1 in order to start PPP. This can be done before or after AT+CFUN=1. Enabled CONFIG_MODEM_BACKEND_UART_ASYNC_HWFC forgotten in PR #6. Jira: SLM-85 Signed-off-by: Tommi Rantanen <tommi.rantanen@nordicsemi.no>
PPP connection has been opened automatically when AT+CFUN=1 is done and PDN has been activated even without PPP request using AT#XPPP=1. This is now changed so you need to issue AT#XPPP=1 in order to start PPP. This can be done before or after AT+CFUN=1. Enabled CONFIG_MODEM_BACKEND_UART_ASYNC_HWFC forgotten in PR #6. Jira: SLM-85 Signed-off-by: Tommi Rantanen <tommi.rantanen@nordicsemi.no>
Jira: SLM-134
Implement PIPE interface to Serial Modem UART to be able to use the same UART implementation for both pure AT-commands and for CMUXed AT-commands and PPP.