[nrf noup] Use proper ZAP package for Linux/Windows with ARM CPUs#601
Merged
ArekBalysNordic merged 1 commit intoMay 9, 2025
Merged
Conversation
|
none Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
kkasperczyk-no
approved these changes
Apr 24, 2025
Contributor
kkasperczyk-no
left a comment
kkasperczyk-no
left a comment
There was a problem hiding this comment.
It looks good to me 👍 Thank you for the contribution!
Currently x86 ZAP is always downloaded on Linux/Windows. This change looks at the architecture of the system to download either x86_64 or arm64 binaries as provided by ZAP releases Signed-off-by: Kendall Goto <kendall@level.co>
kendallgoto
force-pushed
the
kgoto/fix-zap-linux-arch
branch
from
e591f08 to
b2c7790
Compare
|
|
ArekBalysNordic
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently x86 ZAP is always downloaded on Linux & Windows. This change looks at the architecture of the system to download either x86_64 or arm64 binaries as provided by ZAP releases
This is the Linux / Windows equivalent to #574 which similarly downloads ARM64 binaries for Darwin systems on Apple Silicon.