softdevice_controller: Add SDC include dir globally #1561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-rk
force-pushed
the
sdc-include
branch
2 times, most recently
from
d67ffdd to
8e9d87c
Compare
The sdc_soc.h header file is now needed in nrfx_glue.h to set-up event system resource reservations. This requires the header file to be available globally within the build system. Without this change, external libraries that transitively include nrfx_glue.h through zephyr/kernel.h cannot be built. One of such libraries is Matter. Signed-off-by: Rafał Kuźnia <[email protected]>
Contributor
Author
|
@nrfconnect/ncs-co-build-system could you take a look? |
nordicjm
approved these changes
Nov 20, 2024
rugeGerritsen
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sdc_soc.h header file is now needed in nrfx_glue.h to set-up event system resource reservations. This requires the header file to be available globally within the build system.
Without this change, external libraries that transitively include nrfx_glue.h through zephyr/kernel.h cannot be built. One of such libraries is Matter.