softdevice_controller: align to nrfx 4.0 #1878
Conversation
weeTike
left a comment
weeTike
left a comment
There was a problem hiding this comment.
You have to update these files from the dragoon repository. Otherwise your changes will be overwritten next time sdc is updated.
MDK should not be included directly, but via nrfx.h Signed-off-by: Marcin Szymczyk <[email protected]>
masz-nordic
force-pushed
the
NRFX-8398
branch
from
f567d90 to
9b3b433
Compare
masz-nordic
requested review from
a team,
Tschet1,
eriksandgren,
frkv,
leewkb4567,
lopeztel and
tejlmand
as code owners
masz-nordic
force-pushed
the
NRFX-8398
branch
from
26f0814 to
babd4a9
Compare
MDK should not be included directly, but via nrfx.h Signed-off-by: Marcin Szymczyk <[email protected]>
MDK should not be included directly, but via nrfx.h Signed-off-by: Marcin Szymczyk <[email protected]>
MDK should not be included directly, but via nrfx.h Signed-off-by: Marcin Szymczyk <[email protected]>
MDK should not be included directly, but via nrfx.h Signed-off-by: Marcin Szymczyk <[email protected]>
MDK should not be included directly, but via nrfx.h Signed-off-by: Marcin Szymczyk <[email protected]>
MDK should not be included directly, but via nrfx.h Signed-off-by: Marcin Szymczyk <[email protected]>
Since `mpsh_hwres.h` should not use defines from nrfx, the header has to be split. Signed-off-by: Marcin Szymczyk <[email protected]>
masz-nordic
force-pushed
the
NRFX-8398
branch
from
3eb5328 to
3f711df
Compare
|
|
@weeTike this is a WIP targeting non-main branch. Upon nrfx 4.0 release relevant changes will be added to dragoon repo. |
| #ifndef NRF_GZLL_H__ | ||
| #define NRF_GZLL_H__ | ||
|
|
||
| #include <stdbool.h> |
There was a problem hiding this comment.
was it removed accidentally? bool is used in the header file so it makes it cleaner when it is included explicitly
There was a problem hiding this comment.
nrfx.h provides bool so I thought it's more concise. If the preference is to make it explicit, I can change that.
|
Hi @masz-nordic ! I see this is already merged but I think it will be proposed to main branch eventually. I just wanted to let you know that modyfying nrf-802154 files must be done from 802.15.4 radio-driver repository. Doing it this way does not make sense - verification is not reliable and the files would be overwritten in a next deploy. |
4 participants
MDK should not be included directly, but via nrfx.h