Skip to content

GHA: nrf upmerge manual only and PR documentation build#765

Open
ktaborowski wants to merge 2 commits into
nrfconnect:mainfrom
ktaborowski:gha-nrf-cron-disable
Open

GHA: nrf upmerge manual only and PR documentation build#765
ktaborowski wants to merge 2 commits into
nrfconnect:mainfrom
ktaborowski:gha-nrf-cron-disable

Conversation

@ktaborowski
Copy link
Copy Markdown
Contributor

@ktaborowski ktaborowski commented May 28, 2026

Summary

  • NRF upmerge: Remove the weekly cron from nrf-upmerge-pr.yml; keep workflow_dispatch for manual manifest updates.
  • Documentation (DRY): Add reusable documentation_build.yml (Sphinx build + artifacts). Refactor publish_documentation.yml to call it before Zoomin SFTP.
  • PR doc checks: Add on-pr_documentation.yml — runs when doc/** changes on a pull request. Builds only (no Zoomin publish). Fails the check if Sphinx fails (errors in workflow logs). On success, posts a PR comment with links to the workflow run, the documentation-html artifact, and an optional GitHub Pages preview (gh-pages / Pages must be configured).

Test plan

  • Confirm NRF upmerge has Run workflow only (no schedule) after merge.
  • Open or update a PR that touches doc/** and confirm Build documentation on PR runs and passes.
  • Confirm Publish latest documentation / tag publish still work via refactored publish_documentation.yml.
  • Optional: verify Pages preview URL in the PR comment (same-repo PRs only).

@ktaborowski ktaborowski requested a review from a team as a code owner May 28, 2026 10:03
@github-actions github-actions Bot added the source PR changing src files label May 28, 2026
@ktaborowski ktaborowski changed the title GHA: disable weekly schedule on nrf upmerge workflow GHA: nrf upmerge manual only and PR documentation build May 28, 2026
@github-actions
Copy link
Copy Markdown

Sample diff used total

Memory usage did not change for any of the samples.

@github-actions github-actions Bot added the doc-required PR must not be merged without tech writer approval. label May 29, 2026
Remove the cron trigger so NRF manifest update PRs are created
only when the workflow is started manually.

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>
@ktaborowski ktaborowski force-pushed the gha-nrf-cron-disable branch from e7c4a61 to 599b3f0 Compare May 29, 2026 09:44
Extract Sphinx build into reusable documentation_build workflow and
call it from publish_documentation before Zoomin upload. Add
on-pr_documentation to build doc when doc/** changes and post or update
a PR comment with links to the workflow run and documentation zip
artifact.

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>
@ktaborowski ktaborowski force-pushed the gha-nrf-cron-disable branch from 599b3f0 to f09df07 Compare May 29, 2026 10:24
@ktaborowski
Copy link
Copy Markdown
Contributor Author

See how the new doc build works on ktaborowski#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required PR must not be merged without tech writer approval. source PR changing src files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant