GHA: nrf upmerge manual only and PR documentation build#765
Open
ktaborowski wants to merge 2 commits into
Open
GHA: nrf upmerge manual only and PR documentation build#765ktaborowski wants to merge 2 commits into
ktaborowski wants to merge 2 commits into
Conversation
Memory usage did not change for any of the samples. |
Remove the cron trigger so NRF manifest update PRs are created only when the workflow is started manually. Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>
e7c4a61 to
599b3f0
Compare
Extract Sphinx build into reusable documentation_build workflow and call it from publish_documentation before Zoomin upload. Add on-pr_documentation to build doc when doc/** changes and post or update a PR comment with links to the workflow run and documentation zip artifact. Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>
599b3f0 to
f09df07
Compare
Contributor
Author
|
See how the new doc build works on ktaborowski#12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nrf-upmerge-pr.yml; keepworkflow_dispatchfor manual manifest updates.documentation_build.yml(Sphinx build + artifacts). Refactorpublish_documentation.ymlto call it before Zoomin SFTP.on-pr_documentation.yml— runs whendoc/**changes on a pull request. Builds only (no Zoomin publish). Fails the check if Sphinx fails (errors in workflow logs). On success, posts a PR comment with links to the workflow run, thedocumentation-htmlartifact, and an optional GitHub Pages preview (gh-pages/ Pages must be configured).Test plan
doc/**and confirm Build documentation on PR runs and passes.publish_documentation.yml.