More flexible bounding box model#65
Merged
trey-stafford merged 1 commit intomainfrom May 28, 2025
Merged
Conversation
This is much more flexible, but classes that inherit BoundingBox as a field will still raise a validation error if BoundingBox is not initialized with a dict or model instance (e.g. `DatasetSearchParameters`). This is the most likely point that users would define and use a bounding box. Ideally, a user could pass in a list representing a BBOX at the `DatasetSearchParameters` level
Contributor
Author
|
I think this still leaves #51 unresolved, but it is an improvement on the existing interface, so I'll go ahead and merge this. We can continue to make improvements to the user-facing API in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to address #51
This is much more flexible, but classes that inherit BoundingBox as a field will still raise a validation error if BoundingBox is not initialized with a dict or model instance (e.g.
DatasetSearchParameters). This is the most likely point that users would define and use a bounding box. Ideally, a user could pass in a list representing a BBOX at theDatasetSearchParameterslevel.📚 Documentation preview 📚: https://iceflow--65.org.readthedocs.build/en/65/