Transfer meeting ownership - #391
Open
SbirLobo wants to merge 48 commits into
Open
Conversation
Collaborator
|
Attention, la grosse difficulté de ce ticket va être de ne pas perdre la continuité de la salle :
Il y a peut-être d'autres points que j'oublie. |
Collaborator
|
Il faudrait que les admins puissent transférer des salon, soit par l'interface, soit par CLI. |
…ngs under Meeting.id
There's no revision depth left to target once a UUID-backed meeting is in the database
now, we can read meeting.quick
avoid to generate url for each use make meeting url persistents
group_member table wasn't registered when test_join.py ran in isolation, causing User mapper configuration to fail on the group relationship.
meeting.id stay autoincrement integer
azmeuk
reviewed
Sep 1, 2026
Comment on lines
+491
to
+527
| new_owner = delegate | ||
| if new_owner is None or new_owner not in meeting.get_all_delegates: | ||
| abort(404) | ||
|
|
||
| previous_owner = meeting.owner | ||
| meeting.owner = new_owner | ||
| meeting.owner_id = new_owner.id | ||
| new_access = MeetingAccess( | ||
| meeting_id=meeting.id, | ||
| user_id=previous_owner.id, | ||
| level=AccessLevel.DELEGATE, | ||
| ) | ||
| removed_access = MeetingAccess.query.filter_by( | ||
| user_id=new_owner.id, meeting_id=meeting.id | ||
| ).one() | ||
| db.session.add(new_access) | ||
| db.session.delete(removed_access) | ||
| db.session.commit() | ||
| current_app.logger.info( | ||
| "Meeting %s %s have a new owner : %s %s", | ||
| meeting.id, | ||
| meeting.name, | ||
| new_owner.id, | ||
| new_owner.fullname, | ||
| ) | ||
| current_app.logger.info( | ||
| "%s became delegate of meeting %s %s", | ||
| previous_owner.email, | ||
| meeting.id, | ||
| meeting.name, | ||
| ) | ||
| current_app.logger.info( | ||
| "%s removed from delegates of meeting %s %s", | ||
| new_owner.email, | ||
| meeting.id, | ||
| meeting.name, | ||
| ) |
Collaborator
There was a problem hiding this comment.
J'extrairais ça dans une méthode dédiée pour alléger la vue.
azmeuk
reviewed
Sep 1, 2026
| MeetingAccess.meeting_id == self.id, | ||
| MeetingAccess.level == AccessLevel.DELEGATE, | ||
| ) | ||
| .order_by(User.family_name, User.given_name) |
Collaborator
There was a problem hiding this comment.
C'est un peu hors PR, tu peux pousser des choses comme ça directement sur main :) (mais ce n'est pas grave)
azmeuk
marked this pull request as ready for review
September 1, 2026 13:16
Collaborator
|
@Mdl-ac-toulouse pour revue fonctionnelle |
azmeuk
reviewed
Sep 1, 2026
| @check_oidc_connection(auth) | ||
| @auth.oidc_auth("default") | ||
| @meeting_access_required() | ||
| def transfert_meeting_ownership(meeting: Meeting, user: User, delegate: User): |
Collaborator
There was a problem hiding this comment.
À la réflexion, les changements d'état devraient plutôt être derrière des requêtes POST.
azmeuk
reviewed
Sep 1, 2026
| @auth.oidc_auth("default") | ||
| @meeting_access_required() | ||
| def transfert_meeting_ownership(meeting: Meeting, user: User, delegate: User): | ||
| """Display the page for manage meeting delegation.""" |
Collaborator
There was a problem hiding this comment.
Ça ne semble pas être la bonne docstring :)
azmeuk
reviewed
Sep 1, 2026
| } | ||
| text = render_template(f"meeting/mailto/{body_file}.txt", **context) | ||
| html = render_template(f"meeting/mailto/{body_file}.html", **context) | ||
| msg["Subject"] = str(_(f"Transfert de {meeting.name}")) |
Collaborator
There was a problem hiding this comment.
Pas de f-string dans _(...), il faut utiliser _(...).format(...)
azmeuk
reviewed
Sep 1, 2026
| ) | ||
|
|
||
|
|
||
| class TransferMeetingOwnership(FlaskForm): |
Collaborator
There was a problem hiding this comment.
Cette classe n'est jamais appelée non ?
azmeuk
reviewed
Sep 1, 2026
| select = SelectField( | ||
| label=_("Sélectionner un délégataire"), | ||
| description=_( | ||
| "Transférer la propriété d'une réunion est action définitive. Vous deviendrez délégataire de cette réunion." |
azmeuk
reviewed
Sep 1, 2026
| {% include 'meeting/delegation-management.html' %} | ||
| {% endblock %} | ||
|
|
||
| {# |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cette PR est basée sur a #401
fix #329
fix #393
CHANGES
A meeting owner or an admin can transfer ownership of the meeting to a delegate.
The new owner is notified by email.
The previous owner becomes a delegate for the meeting.