Transfer meeting ownership

web/b3desk/endpoints/meetings.py

@@ -46,6 +46,7 @@
 from ..session import is_admin_mode
 from ..session import meeting_access_required
 from ..utils import send_delegation_mail
+from ..utils import send_new_owner_mail
 
 bp = Blueprint("meetings", __name__)
 
@@ -479,3 +480,68 @@ def remove_delegate(meeting: Meeting, user: User, delegate: User):
             admin_mode=is_admin_mode() or None,
         )
     )
+
+
+@bp.route("/meeting/transfert-meeting-ownership/<meeting:meeting>/<user:delegate>")
+@check_oidc_connection(auth)
+@auth.oidc_auth("default")
+@meeting_access_required()
+def transfert_meeting_ownership(meeting: Meeting, user: User, delegate: User):
+    """Display the page for manage meeting delegation."""
+    new_owner = delegate
+    if new_owner is None or new_owner not in meeting.get_all_delegates:
+        abort(404)
+
+    previous_owner = meeting.owner
+    meeting.owner = new_owner
+    meeting.owner_id = new_owner.id
+    new_access = MeetingAccess(
+        meeting_id=meeting.id,
+        user_id=previous_owner.id,
+        level=AccessLevel.DELEGATE,
+    )
+    removed_access = MeetingAccess.query.filter_by(
+        user_id=new_owner.id, meeting_id=meeting.id
+    ).one()
+    db.session.add(new_access)
+    db.session.delete(removed_access)
+    db.session.commit()
+    current_app.logger.info(
+        "Meeting %s %s have a new owner : %s %s",
+        meeting.id,
+        meeting.name,
+        new_owner.id,
+        new_owner.fullname,
+    )
+    current_app.logger.info(
+        "%s became delegate of meeting %s %s",
+        previous_owner.email,
+        meeting.id,
+        meeting.name,
+    )
+    current_app.logger.info(
+        "%s removed from delegates of meeting %s %s",
+        new_owner.email,
+        meeting.id,
+        meeting.name,
+    )
+    flash(
+        _(
+            "%(owner_name)s est le nouveau propriétaire de %(meeting_name)s",
+            owner_name=new_owner.fullname,
+            meeting_name=meeting.name,
+        ),
+        "success",
+    )
+    send_delegation_mail(meeting, previous_owner, new_delegation=True)
+    send_new_owner_mail(meeting, new_owner, previous_owner)
+    return (
+        redirect(url_for("public.welcome"))
+        if not is_admin_mode()
+        else redirect(
+            url_for(
+                "admin.meeting_infos",
+                meeting=meeting,
+            )
+        )
+    )

web/b3desk/forms.py

@@ -294,6 +294,17 @@ class MeetingSearchForm(FlaskForm):
     )
 
 
+class TransferMeetingOwnership(FlaskForm):
+    select = SelectField(
+        label=_("Sélectionner un délégataire"),
+        description=_(
+            "Transférer la propriété d'une réunion est action définitive. Vous deviendrez délégataire de cette réunion."
+        ),
+        validators=[validators.DataRequired()],
+        choices=[],
+    )
+
+
 class GroupSearchForm(FlaskForm):
     search = StringField(
         label=_("Rechercher un groupe"),

web/b3desk/models/meetings.py

@@ -233,6 +233,7 @@ def get_all_delegates(self):
                 MeetingAccess.meeting_id == self.id,
                 MeetingAccess.level == AccessLevel.DELEGATE,
             )
+            .order_by(User.family_name, User.given_name)
         ).all()
 
     def url_for_role(self, role):

web/b3desk/templates/meeting/delegation-management.html

@@ -31,8 +31,9 @@ <h6>{% trans %} Ajouter des délégataires {% endtrans %}</h6>
                             <table id="delegation">
                                 <thead class="">
                                     <tr class="">
-                                        <th class="fr-col--lg fr-cell--center"> Liste des délégataires </th>
-                                        <th class="fr-col--xs fr-cell--center"> {{ meeting.get_all_delegates|length }}/{{ config.get("MAXIMUM_MEETING_DELEGATES") }} </th>
+                                        <th class="fr-col--lg fr-cell--center">{% trans %}Liste des délégataires{% endtrans %} ({{ meeting.get_all_delegates|length }}/{{ config.get("MAXIMUM_MEETING_DELEGATES") }})</th>
+                                        <th class="fr-col--xs fr-cell--center">{% trans %}Retirer{% endtrans %}</th>
+                                        <th class="fr-col--xs fr-cell--center">{% trans %}Transférer{% endtrans %}</th>
                                     </tr>
                                 </thead>
                                 <tbody class="">
@@ -42,6 +43,9 @@ <h6>{% trans %} Ajouter des délégataires {% endtrans %}</h6>
                                             <td class="fr-col--xs fr-cell--center">
                                                 <a class="fr-btn fr-btn--secondary fr-fi-delete-line" title="{% trans %}Retirer le délégataire{% endtrans %}" href="{{ url_for("meetings.remove_delegate", meeting=meeting, delegate=delegate, admin_mode=admin_mode or None) }}"></a>
                                             </td>
+                                            <td class="fr-col--xs fr-cell--center">
+                                                <button class="fr-btn fr-icon-share-forward-line fr-btn--delete" data-fr-opened="false" aria-controls="transfert-ownership-confirmation-{{ delegate.id }}" title="{% trans meeting_name=meeting.name %}Transférer {{ meeting_name }}{% endtrans %}"></button>
+                                            </td>
                                         </tr>
                                     {% endfor %}
                                 </tbody>
@@ -53,3 +57,6 @@ <h6>{% trans %} Ajouter des délégataires {% endtrans %}</h6>
         </div>
     </div>
 </div>
+{% for delegate in meeting.get_all_delegates %}
+    {% include 'meeting/modals/transfert-ownership-confirmation.html' %}
+{% endfor %}

web/b3desk/templates/meeting/delegation.html

@@ -29,3 +29,8 @@
     {% endif %}
     {% include 'meeting/delegation-management.html' %}
 {% endblock %}
+
+{#
+fr-icon-arrow-right-s-line-double
+fr-icon-share-forward-line
+  #}

web/b3desk/templates/meeting/mailto/mail_new_owner_body.html

@@ -0,0 +1,12 @@
+<html>
+    {% trans %}Bonjour{% endtrans %} {{ new_owner.given_name }} {{ new_owner.family_name }},
+    <br/>
+    <br/>
+    {{ previous_owner.fullname }} {% trans %}vous a transféré la propriété de la réunion{% endtrans %} {{ meeting.name }}.
+    <br/>
+    <br/>
+    {% trans %}Vous pouvez dès à présent consulter et gérer les délégataires, l'édition, les enregistrements et les fichiers associés à cette réunion.{% endtrans %}
+    <br/>
+    <br/>
+    {% trans %}Rendez vous simplement sur <a href="{{ welcome_url }}">votre espace</a>.{% endtrans %}
+</html>

web/b3desk/templates/meeting/mailto/mail_new_owner_body.txt

@@ -0,0 +1,7 @@
+{% trans %}Bonjour{% endtrans %} {{ new_owner.given_name }} {{ new_owner.family_name }},
+
+{{ previous_owner.fullname }} {% trans %}vous a transféré la propriété de la réunion{% endtrans %} {{ meeting.name }}.
+
+{% trans %}Vous pouvez dès à présent consulter et gérer les délégataires, l'édition, les enregistrements et les fichiers associés à cette réunion.{% endtrans %}
+
+{% trans %}Rendez-vous simplement sur votre espace :{% endtrans %} {{ welcome_url }}

web/b3desk/templates/meeting/modals/transfert-ownership-confirmation.html

@@ -0,0 +1,41 @@
+<dialog id="transfert-ownership-confirmation-{{ delegate.id }}" class="fr-modal" role="dialog" aria-labelledby="transfert-ownership-confirmation-{{ delegate.id }}-title">
+    <div class="fr-container fr-container--fluid fr-container-md">
+        <div class="fr-grid-row fr-grid-row--center">
+            <div class="fr-col-12 fr-col-md-8 fr-col-lg-6">
+                <div class="fr-modal__body">
+                    <div class="fr-modal__header">
+                        <button class="fr-btn--close fr-btn" aria-controls="transfert-ownership-confirmation-{{ delegate.id }}" title="{% trans %}Fermer{% endtrans %}">
+                            {% trans %}Fermer{% endtrans %}
+                        </button>
+                    </div>
+                    <div class="fr-modal__content">
+                        <h1 id="transfert-ownership-confirmation-{{ delegate.id }}-title" class="fr-modal__title">
+                            {% trans meeting_name=meeting.name %}Transférer "{{ meeting_name }}" ?{% endtrans %}
+                        </h1>
+                        <p>{% trans meeting_name=meeting.name, delegate_name=delegate.fullname %}Voulez-vous vraiment transférer la propriété de "{{ meeting_name }}" à {{ delegate_name }} ?{% endtrans %}</p>
+                        <div class="fr-notice fr-notice--info">
+                            <div class="fr-container">
+                                <div class="fr-notice__body">
+                                    <p class="fr-notice__title">{% trans %}La confirmation est définitive.{% endtrans %}</p>
+                                </div>
+                                <p>{% trans %}Vous deviendrez délégataire de cette réunion.{% endtrans %}</p>
+                            </div>
+                        </div>
+                    </div>
+                    <div class="fr-modal__footer">
+                        <ul class="fr-btns-group fr-btns-group--inline-reverse fr-btns-group--inline-lg fr-btns-group--right">
+                            <li>
+                                <a class="fr-btn fr-btn--delete" href="{{ url_for("meetings.transfert_meeting_ownership", meeting=meeting, delegate=delegate, admin_mode=admin_mode or None) }}">
+                                    {% trans %}Confirmer{% endtrans %}
+                                </a>
+                            </li>
+                            <li>
+                                <button type="button" class="fr-btn fr-btn--secondary" aria-controls="transfert-ownership-confirmation-{{ delegate.id }}" title="{% trans %}Annuler{% endtrans %}">{% trans %}Annuler{% endtrans %}</button>
+                            </li>
+                        </ul>
+                    </div>
+                </div>
+            </div>
+        </div>
+    </div>
+</dialog>

web/b3desk/utils/__init__.py

@@ -91,6 +91,26 @@ def send_delegation_mail(meeting, delegate, new_delegation: bool):
     send_email(msg, text, html, smtp)
 
 
+def send_new_owner_mail(meeting, new_owner, previous_owner):
+    """Send email to inform the new meeting owner."""
+    smtp = make_smtp()
+    msg = EmailMessage()
+    body_file = "mail_new_owner_body"
+    context = {
+        "meeting": meeting,
+        "new_owner": new_owner,
+        "previous_owner": previous_owner,
+        "welcome_url": url_for("public.welcome", _external=True),
+    }
+    text = render_template(f"meeting/mailto/{body_file}.txt", **context)
+    html = render_template(f"meeting/mailto/{body_file}.html", **context)
+    msg["Subject"] = str(_(f"Transfert de {meeting.name}"))
+    msg["From"] = smtp["from_email"]
+    msg["To"] = new_owner.email
+
+    send_email(msg, text, html, smtp)
+
+
 def _build_recording_links(playbacks):
     """Return an ordered list of {label, url} entries from a BBB playbacks dict."""
     links = []

web/tests/meeting/test_transfert_ownership.py

@@ -0,0 +1,34 @@
+from b3desk.models import db
+from b3desk.models.meetings import AccessLevel
+from b3desk.models.meetings import MeetingAccess
+
+
+def test_owner_can_transfer_ownership_to_delegate(
+    client_app, authenticated_user, user_2, meeting, user, smtpd, caplog
+):
+    """Test owner can transfer ownership to delegate."""
+    new_access = MeetingAccess(
+        meeting_id=meeting.id,
+        user_id=user_2.id,
+        level=AccessLevel.DELEGATE,
+    )
+    db.session.add(new_access)
+    db.session.commit()
+    client_app.get("/meeting/transfert-meeting-ownership/1/2", status=302)
+    assert meeting.owner is user_2
+    assert user in meeting.get_all_delegates
+    assert len(smtpd.messages) == 2
+    assert "Meeting 1 meeting have a new owner : 2 Berenice Cooler" in caplog.text
+    assert "alice@domain.tld became delegate of meeting 1 meeting" in caplog.text
+    assert (
+        "berenice@domain.tld removed from delegates of meeting 1 meeting" in caplog.text
+    )
+    assert "Email sent to alice@domain.tld" in caplog.text
+    assert "Email sent to berenice@domain.tld" in caplog.text
+
+
+def test_new_owner_is_not_delegate_display_404(
+    client_app, authenticated_user, meeting, user_2
+):
+    """Test form displays message if form is empty."""
+    client_app.get("/meeting/transfert-meeting-ownership/1/2", status=404)