SERVER: Fixed fall damage formula incorrectly dealing max damage at all distances#138
Merged
Merged
Conversation
MotoLegacy
approved these changes
Aug 28, 2025
Member
MotoLegacy
left a comment
MotoLegacy
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up a bit. Note to myself to separate this into a separate function and draft a unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The fall damage formula previously always dealt the maximum damage of 98 due to the damage not being subtracted by 176 (the minimum fall damage distance)
This PR fixes that by using the height minus 176 when applying the damage formula.
Visual Sample
In the previous behavior, a fall from any height over 176 dealt 98 damage, but in the new behavior, the damage scales by height.
(look top-left showing the damage after falling)
Previous behavior:
https://github.com/user-attachments/assets/b9e61a07-1b4d-4af8-adb0-32e2a88cd95b
New behavior:
https://github.com/user-attachments/assets/a293498a-d8db-45d6-9226-d6c37b85884a
Checklist