PopcornFX assets: Cleanup graph locations#417
Closed
HugoPKFX wants to merge 1 commit intoo3de:developmentfrom
Closed
PopcornFX assets: Cleanup graph locations#417HugoPKFX wants to merge 1 commit intoo3de:developmentfrom
HugoPKFX wants to merge 1 commit intoo3de:developmentfrom
Conversation
mbalfour-amzn
approved these changes
May 25, 2023
Contributor
|
You'll need to fix the DCO signing on your commits. |
Author
|
Hi @mbalfour-amzn, Sorry, re-created a different PR with the commit correctly signed this time: #421 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not touch effects behavior, only improves user experience when opening an effect.
Opening an effect (for most of them or a layer), we did not see any nodes. Had to pan the view to find where they are.
Captured nodegraph view location with bound nodes (did that for all effects under
Particles/folder:Note: effects were opened & saved with PopcornFX Editor 2.16.3 (project was already upgraded to 2.16.2), this has no effect on the gem (effects will be re-baked without issues without needing a gem upgrade).