chore: fix publish workflow #706
Conversation
| id-token: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - run: npx jsr publish |
There was a problem hiding this comment.
Publish workflow is failing because the jsr binary is pinned to an old version of Deno and that pulls in an old @types/node version :/
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| - name: install deno | ||
| uses: denoland/setup-deno@v2 | ||
| with: | ||
| deno-version: 2.x |
There was a problem hiding this comment.
Bug: Version mismatch between CI and publish workflows
The CI workflow tests with canary Deno version while the publish workflow uses 2.x. This version mismatch means code could pass CI tests on canary but fail during publishing with a stable 2.x version, or vice versa. The published package isn't guaranteed to work with the Deno version it was tested against.
Additional Locations (1)
2 participants
Note
Update GitHub Actions to use setup-deno v2 and switch publish step to
deno publishwith Deno 2.x..github/workflows/ci.yml): Upgradedenoland/setup-denofromv1tov2..github/workflows/publish.yml): Install Deno viadenoland/setup-deno@v2(use2.x) and replacenpx jsr publishwithdeno publish.Written by Cursor Bugbot for commit 6a005b8. This will update automatically on new commits. Configure here.