Skip to content

chore: fix publish workflow #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2025
Merged

chore: fix publish workflow #706

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dc4369
chore: fix publish workflow
dsherret Nov 22, 2025
6a005b8
Merge branch 'main' into fix_publish_workflow
kitsonk Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
uses: actions/checkout@v4

- name: install deno
uses: denoland/setup-deno@v1
uses: denoland/setup-deno@v2
with:
deno-version: ${{ matrix.version }}

Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,8 @@ jobs:
id-token: write
steps:
- uses: actions/checkout@v4
- run: npx jsr publish
Copy link
Contributor Author

@dsherret dsherret Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publish workflow is failing because the jsr binary is pinned to an old version of Deno and that pulls in an old @types/node version :/

jsr-io/jsr-npm#130

- name: install deno
uses: denoland/setup-deno@v2
with:
deno-version: 2.x
Copy link

@cursor cursor bot Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Version mismatch between CI and publish workflows

The CI workflow tests with canary Deno version while the publish workflow uses 2.x. This version mismatch means code could pass CI tests on canary but fail during publishing with a stable 2.x version, or vice versa. The published package isn't guaranteed to work with the Deno version it was tested against.

Additional Locations (1)

Fix in Cursor Fix in Web

- run: deno publish