Add attribute_location_during_activity DOSDP and terms in the pattern#394
Conversation
Introduces the attribute_location_during_activity DOSDP pattern, supporting data and new classes for 'level of glucose in blood during fasting' and 'level of insulin in blood during fasting'. Updates definitions.owl with new class and property declarations and version info.
Replaces the 'happens_during' (RO_0002092) relation with 'collected_during' (RO_0017502) in the attribute_location_during_activity DOSDP.
|
I have added obi imports. I need NCIT for other terms in #391, can I keep the addition of this import here, or remove from this PR and re-add it in the new PR? |
Replaced NCIT:C63663 with OBI:0003653 for fasting activity in TSV and OWL files. Updated logical definition in attribute_location_during_activity.yaml to nest 'collected_during' within the entity's location
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
Looks great - a few comments!
| mirror_type: custom | ||
| - id: lipidmaps | ||
| mirror_type: custom | ||
| - id: NCIT |
There was a problem hiding this comment.
can we make this lower case - mixing cases in filenames just causes confusion in downstream applications.
| @@ -0,0 +1,3 @@ | |||
| defined_class defined_class_name entity entity_name attribute attribute_name location location_name activity activity_name exact_synonyms broad_synonyms narrow_synonyms xrefs orcid usage_notes | |||
| OBA:2090000 level of glucose in blood during fasting CHEBI:17234 glucose PATO:0000070 amount UBERON:0000178 blood OBI:0003653 fasting | |||
There was a problem hiding this comment.
Check with @ar-ibrahim if these are the correct glucose and insulin terms, I seem to remember there are so many always.
There was a problem hiding this comment.
Thanks for checking, I have used the same CHEBI terms used in blood glucose amount (OBA:VT0000188) and amount of insulin in blood (OBA:2060174).
| quality: PATO:0000001 | ||
| entity: owl:Thing | ||
| location: UBERON:0001062 | ||
| activity: owl:Thing |
There was a problem hiding this comment.
hack.. a bit unfortunate, but I am not too bothered.
There was a problem hiding this comment.
I wasn't sure how to restrict activity. It made sense to restrict to the activity branch in NCIT, but now we are using the term from OBI, which is a planned process.
3 participants
Introduces the attribute_location_during_activity DOSDP pattern, supporting data and new classes for 'level of glucose in blood during fasting' and 'level of insulin in blood during fasting'. Updates definitions.owl with new class and property declarations and version info.