Skip to content

Fix raw formats #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix raw formats #61

wants to merge 1 commit into from

Conversation

xiaozhuai
Copy link

No description provided.

@Fenrirthviti
Copy link
Member

Please properly fill out the PR template.

@BillyONeal
Copy link

else if (mt.subtype == MEDIASUBTYPE_IYUV)
format = VideoFormat::I420;

also looks like it might be a copy pasto. (I have no idea what this code does, I'm just looking for the pattern that the format 'kind' seems to usually match elsewhere in this file)

@BillyONeal
Copy link

Possibly related: 5ac25cb

@Fenrirthviti Can you clarify what you mean by PR template?
@xiaozhuai Can you try to follow the PR template?

@Fenrirthviti
Copy link
Member

I'm not sure what needs clarifying. Our repo requires all PRs to use our PR template, provided as part of the GitHub repo config. I'm baffled how this was even submitted without using one, as it's required to submit a PR to us. It was either using some third-party client that bypasses this repo setting, or the user explicitly looked at the template and chose to delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants