overlay: pin matrix-appservice-irc to nodejs-slim 22#370
Merged
Conversation
Member
|
pls no claude trailer |
Member
Author
|
okok |
Co-Authored-By: jaysa68 <jaysagarcia@berkeley.edu>
sophiebsw
force-pushed
the
irc-node-patch
branch
from
July 13, 2026 23:44
6bef946 to
0000835
Compare
sophiebsw
approved these changes
Jul 13, 2026
dotlambda
reviewed
Jul 14, 2026
|
|
||
| # https://github.com/matrix-org/matrix-appservice-irc/issues/1861 | ||
| matrix-appservice-irc = prev.matrix-appservice-irc.override { | ||
| nodejs-slim = final.nodejs-slim_22; |
Contributor
There was a problem hiding this comment.
I'm confused. The upstream issue says Node,js 22 broke something. So shouldn't this be
Suggested change
| nodejs-slim = final.nodejs-slim_22; | |
| nodejs-slim = final.nodejs-slim_20; |
?
But that's EOL and marked insecure in Nixpkgs.
There was a problem hiding this comment.
For me it works with node 22, so yeah, I guess the upstream issue is wrong. For me this has been broken for quite a while but haven't had the time to look into it. And I'm a bit surprised that it took me like 7 months to get around to it and that no one else fixed it in nixpkgs before that 😅
Contributor
|
I guess the upstream issue is just wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed for irc martix bridge to work again