Skip to content

overlay: pin matrix-appservice-irc to nodejs-slim 22 #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sophiebsw merged 1 commit into from
Jul 13, 2026
Merged

overlay: pin matrix-appservice-irc to nodejs-slim 22 #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,11 @@
nativeBuildInputs = (old.nativeBuildInputs or [ ]) ++ [ final.rpcsvc-proto ];
configureFlags = (old.configureFlags or [ ]) ++ [ "--enable-rpc" ];
});

# https://github.com/matrix-org/matrix-appservice-irc/issues/1861
matrix-appservice-irc = prev.matrix-appservice-irc.override {
nodejs-slim = final.nodejs-slim_22;

@dotlambda dotlambda Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. The upstream issue says Node,js 22 broke something. So shouldn't this be

Suggested change
nodejs-slim = final.nodejs-slim_22;
nodejs-slim = final.nodejs-slim_20;

?
But that's EOL and marked insecure in Nixpkgs.

@etu etu Jul 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it works with node 22, so yeah, I guess the upstream issue is wrong. For me this has been broken for quite a while but haven't had the time to look into it. And I'm a bit surprised that it took me like 7 months to get around to it and that no one else fixed it in nixpkgs before that 😅

};
};

agenix-rekey = agenix-rekey.configure {
Expand Down
Loading