Restore module type of in project_name_icons (waiting on OCaml fix)#4
Closed
Restore module type of in project_name_icons (waiting on OCaml fix)#4
Conversation
Replace the named signature [ICON_HTML] (workaround for the OCaml strengthening bug in wrapped libraries) with the original [module type of Eliom.Content.Html.F] pattern. The OCaml bug has been identified and patched (see ia-reports/2026-04-ocaml-wrapped-mtof-bug.md). Once the patch is available upstream, this revert can be merged. Until then this PR stays as a draft to track the work. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the named signature [ICON_HTML] in
project_name_icons.eliomwithmodule type of Eliom.Content.Html.F, the original pre-wrapping pattern. The named signature was introduced as a workaround for an OCaml strengthening bug.The bug has been identified and patched. See ia-reports/2026-04-ocaml-wrapped-mtof-bug.md for the full investigation.
Status
Draft — held until the OCaml fix is available upstream and the template's minimum required OCaml version requires it.
🤖 Generated with Claude Code