Skip to content

Restore module type of in project_name_icons (waiting on OCaml fix) #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
balat wants to merge 1 commit into from
+1 −11
Closed

Restore module type of in project_name_icons (waiting on OCaml fix) #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions project_name_icons.eliom
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,7 @@
http://fontawesome.io/ for more information and for the complete
list of CSS classes values. *)

(* Named signature instead of [module type of Eliom.Content.Html.F]
to work around OCaml wrapped module path identity issue. *)
module type%shared ICON_HTML = sig
val i :
?a:[< Html_types.i_attrib] Eliom.Content.Html.attrib list
-> [< Html_types.i_content_fun] Eliom.Content.Html.elt list
-> [> Html_types.i] Eliom.Content.Html.elt
val a_class : Html_types.nmtokens -> [> `Class] Eliom.Content.Html.attrib
end

module%shared Make (A : ICON_HTML) = struct
module%shared Make (A : module type of Eliom.Content.Html.F) = struct
(** [icon classes ~a:other_css_classes ()] create an icon HTML
attribute with "fa" and [classes] as CSS classes. The HTML tag
"i" is used because it is the de facto standard for icons. The
Expand Down