19.0 tutorials joyep #1036
Open
19.0 tutorials joyep #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yewentai
force-pushed
the
19.0-tutorials-joyep
branch
6 times, most recently
from
e9da80b to
c526e50
Compare
antonrom1
reviewed
Nov 20, 2025
antonrom1
left a comment
antonrom1
left a comment
There was a problem hiding this comment.
Look really good overall, good job :P
estate/views/estate_menus.xml
Outdated
Comment on lines
3
to
14
| <menuitem id="estate_menu_root" name="Real Estate"/> | ||
|
|
||
| <menuitem id="estate_property_menu_categ" | ||
| name="Properties" | ||
| parent="estate_menu_root" | ||
| sequence="10"/> | ||
|
|
||
| <menuitem id="estate_property_menu_action" | ||
| name="Properties" | ||
| parent="estate_property_menu_categ" | ||
| action="estate_property_action" | ||
| sequence="20"/> |
There was a problem hiding this comment.
Good! 👍
Just as a note, you can also define them like this instead of specifying the parent
Comment on lines
60
to
100
| @api.depends("living_area", "garden_area") | ||
| def _compute_total_area(self): | ||
| for record in self: | ||
| record.total_area = record.living_area + record.garden_area | ||
|
|
||
| total_area = fields.Integer("Total Area (sqm)", compute="_compute_total_area", store=True) | ||
|
|
||
| @api.depends("offer_ids.price") | ||
| def _compute_best_offer(self): | ||
| for record in self: | ||
| prices = record.offer_ids.mapped("price") | ||
| record.best_offer = max(prices) if prices else 0.0 | ||
|
|
||
| best_offer = fields.Float("Best Offer", compute="_compute_best_offer", store=True) | ||
|
|
||
| @api.onchange("garden") | ||
| def _onchange_garden(self): | ||
| if not self.garden: | ||
| self.garden_area = 0 | ||
| self.garden_orientation = False | ||
| else: | ||
| if not self.garden_area: | ||
| self.garden_area = 10 | ||
| if not self.garden_orientation: | ||
| self.garden_orientation = "north" |
There was a problem hiding this comment.
In a Model attribute order should be
- Private attributes (_name, _description, _inherit, …)
- Default method and default_get
- Field declarations
- SQL constraints and indexes
- Compute, inverse and search methods in the same order as field declaration
- Selection method (methods used to return computed values for selection fields)
- Constrains methods (@api.constrains) and onchange methods (@api.onchange)
- CRUD methods (ORM overrides)
- Action methods
- And finally, other business methods.
Comment on lines
43
to
55
| other_offers = self.search( | ||
| [ | ||
| ("property_id", "=", offer.property_id.id), | ||
| ("id", "!=", offer.id), | ||
| ] | ||
| ) |
There was a problem hiding this comment.
it's good, but you can make it a bit simpler. Recordsets have bitwise operations (__sub__, __or__, __and__ etc)
Suggested change
| other_offers = self.search( | |
| [ | |
| ("property_id", "=", offer.property_id.id), | |
| ("id", "!=", offer.id), | |
| ] | |
| ) | |
| other_offers = self.property_id.offer_ids - offer |
Also check that none other offers were already accepted. e.g.:
if any(other_offers.filtered(lambda o: o.status == 'accepted')): ...
estate/models/estate_property.py
Outdated
Comment on lines
1
to
3
| from odoo import api, fields, models | ||
| from odoo.exceptions import UserError | ||
| from dateutil.relativedelta import relativedelta |
There was a problem hiding this comment.
nitpick: import order https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#imports
Suggested change
| from odoo import api, fields, models | |
| from odoo.exceptions import UserError | |
| from dateutil.relativedelta import relativedelta | |
| from dateutil.relativedelta import relativedelta | |
| from odoo import api, fields, models | |
| from odoo.exceptions import UserError |
Comment on lines
18
to
26
| date_availability = fields.Date( | ||
| "Available From", default=lambda self: fields.Date.today() + relativedelta(months=3), copy=False | ||
| ) |
There was a problem hiding this comment.
Don't forget the trailing comma. Also making this multiline would look better imo
estate/models/__init__.py
Outdated
Comment on lines
2
to
4
| from . import estate_property_type | ||
| from . import estate_property_tag | ||
| from . import estate_property_offer |
yewentai
force-pushed
the
19.0-tutorials-joyep
branch
9 times, most recently
from
d851b07 to
b65f969
Compare
added 6 commits
November 20, 2025 14:37
yewentai
force-pushed
the
19.0-tutorials-joyep
branch
from
b65f969 to
b565d8b
Compare
added 4 commits
November 20, 2025 14:46
Add property types, tags, and offers with corresponding views and access rights
Enhance property and offer models with computed fields and views
Implement action methods for property status and offer status
Add SQL constraints for price and uniqueness in property models and add Python constraints for the accepted price.
yewentai
force-pushed
the
19.0-tutorials-joyep
branch
from
b565d8b to
859d32c
Compare
Enhance property management - update launch configuration, modify ordering, and improve views
Implement inherited user model and views, add CRUD validation for property offers
yewentai
force-pushed
the
19.0-tutorials-joyep
branch
from
1305fc1 to
d8b4942
Compare
added 5 commits
November 26, 2025 15:02
Initial implementation of estate module with property management features
update module structure and enhance Playground component
yewentai
force-pushed
the
19.0-tutorials-joyep
branch
from
39c6702 to
935914a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.