Skip to content

Resized ward pins #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Resized ward pins #587

merged 1 commit into from
Dec 13, 2016

Conversation

dartharaknus
Copy link
Member

Fixes #445

xmlns="http://www.w3.org/2000/svg"
>
<g>
<title>Observer</title>
<title>{log.type === 'observer' ? 'Observer' : 'Sentry'}</title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

externalize the strings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@howardchung
Copy link
Member

LGTM, some lint issue?

@dartharaknus
Copy link
Member Author

I imported 'strings' instead of 'lang'

@howardchung
Copy link
Member

/home/travis/build/odota/ui/src/components/Match/VisionMap.jsx
  26:62  error  Infix operators must be spaced  space-infix-ops

@dartharaknus
Copy link
Member Author

@howardchung Fixed now.

@howardchung
Copy link
Member

sync master? one of the CI checks is failing

@dartharaknus
Copy link
Member Author

Rebased on master.

@howardchung howardchung merged commit ff173f3 into master Dec 13, 2016
@howardchung howardchung deleted the darth/ward-radius branch December 13, 2016 16:30
masad-frost pushed a commit to masad-frost/ui that referenced this pull request Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants