Skip to content

Improve ward map visuals #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Improve ward map visuals #445

wants to merge 2 commits into from

Conversation

mjbcopland
Copy link

@mjbcopland mjbcopland commented Nov 8, 2016 •
edited
Loading

  • Enlarged observer wards on the map to reflect their larger AoE compared to sentries
  • Replaced team colours with individual player colours
Original Updated
Original Updated

howardchung
howardchung approved these changes Nov 8, 2016
View reviewed changes
Copy link
Member

@howardchung howardchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dartharaknus
dartharaknus requested changes Nov 8, 2016
View reviewed changes
src/components/Match/VisionMap.jsx
@@ -20,7 +20,7 @@ import {
const obsWard = (style, stroke, iconSize) => (<svg style={style} width={iconSize} height={iconSize} xmlns="http://www.w3.org/2000/svg">
<g>
<title>Observer</title>
<circle fill="#ffff00" strokeWidth="5" stroke={stroke} r={iconSize * 0.4} cy={iconSize / 2} cx={iconSize / 2} fillOpacity="0.4" />
<circle fill="#ffff00" strokeWidth="2.5" stroke={stroke} r={iconSize * 0.4} cy={iconSize / 2} cx={iconSize / 2} fillOpacity="0.3" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this 2.5 and not 2?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have 2 for sentries. And since this is just the border, I think both of them should have the same value 2.

src/components/Match/VisionMap.jsx
@@ -32,7 +32,7 @@ const obsWard = (style, stroke, iconSize) => (<svg style={style} width={iconSize
const senWard = (style, stroke, iconSize) => (<svg style={style} width={iconSize} height={iconSize} xmlns="http://www.w3.org/2000/svg">
<g>
<title>Sentry</title>
<circle fill="#0000ff" strokeWidth="5" stroke={stroke} r={iconSize * 0.4} cy={iconSize / 2} cx={iconSize / 2} fillOpacity="0.4" />
<circle fill="#0000ff" strokeWidth="2" stroke={stroke} r={iconSize * 0.4} cy={iconSize / 2} cx={iconSize / 2} fillOpacity="0.3" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this a cyan color?

@dartharaknus
Copy link
Member

@howardchung I am not too keen on the player color. We already have player specific switches. I think the map should have just team color.

@mjbcopland
Copy link
Author

  • When the observer radius is larger than that of sentries, both having the same stroke thickness gives the illusion that observers have a thinner outline (see the Ebbinghaus illusion). Increasing the thickness negates this effect to give the appearance that they are the same. If you disagree, I can make them actually consistent with each other.
  • Feel free to tweak the AoE colours; I kept them as they were. Cyan seems a bit too far in the other direction but perhaps something in between?
#0000FF #007FFF #00FFFF
Blue Azure Cyan
  • The use of individual hero colours was partially motivated by this comment. Colours seemed cleaner and easier than icons.

@dartharaknus
Copy link
Member

Okay, different thickness it is. TIL. 😄

How about #0055FF?

Can you also add tooltips to each of those circles containing information about who planted the ward, when, who destroyed it if any, when if any

@howardchung
Copy link
Member

  • Maybe leave a comment in the code explaining why we have different stroke widths
  • I like #007FFF but we can play around with that range if we want
  • Tooltips for icons are probably outside the scope of this PR. @micaelbergeron is working an improved scrubbable vision map, perhaps he can add tooltips as well.

@micaelbergeron
Copy link

I'll try to merge this into #469

This was referenced Nov 12, 2016
Merged
Closed
@dartharaknus
Copy link
Member

@howardchung What's the plan with moving forward on this one?

@howardchung
Copy link
Member

Needs to be synced with @micaelbergeron 's merged PR. I think we can apply the larger ward radius. Not sure if we want to do the colors as well.

@dartharaknus dartharaknus mentioned this pull request Dec 12, 2016
Merged
@dartharaknus
Copy link
Member

Being done in #587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dartharaknus dartharaknus dartharaknus requested changes

@howardchung howardchung howardchung approved these changes

Assignees
No one assigned
Labels
scope: ux type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjbcopland @dartharaknus @howardchung @micaelbergeron