chore(xcelium): remove the -enable_cmdline_define_redefinition argument - #558
Open
tymonx wants to merge 1 commit into
Open
chore(xcelium): remove the -enable_cmdline_define_redefinition argument#558tymonx wants to merge 1 commit into
tymonx wants to merge 1 commit into
Conversation
tymonx
force-pushed
the
feature/xcelium-remove-enable_cmdline_define_redefinition
branch
from
August 11, 2026 09:36
1cd918a to
c0c1002
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #532
This is not needed because every group of files is compiled by using the
-makelib <library> <options>... <file> -endlibthat is creating own scope where options like-define NAME=VALUEare not interleaving with each other.Each groups of files is created based on files, library name and defines:
edalize/edalize/tools/xcelium.py
Lines 150 to 164 in e8feae4
Additionally, the
libis always present and it is not empty:edalize/edalize/tools/xcelium.py
Line 140 in e8feae4
In case of the Xcelium simulator, if user doesn't provide the library name explicitly, everything is compiled under the default library
worklib.So this:
Could be replaced with explicitly
-makelib worklib <options> <file> -endlib:And the
-enable_cmdline_define_redefinitionargument is not needed. That argument is not documented, not present in thexrun -helpalland it is not supported by the Cadence Xcelium below version 25.