Skip to content

Fix dependencies#17

Merged
khaledk2 merged 5 commits intoome:masterfrom
khaledk2:remove_dependencies
Mar 14, 2026
Merged

Fix dependencies#17
khaledk2 merged 5 commits intoome:masterfrom
khaledk2:remove_dependencies

Conversation

@khaledk2
Copy link
Copy Markdown
Collaborator

No description provided.

@khaledk2 khaledk2 requested a review from pwalczysko March 12, 2026 10:08

OMERO.docker.web is required.


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, imho this still does not make sense. Nobody (including myself) knows what OMERO.docker.web is. And also, I do not believe that it is required.

Please remove the sentence

OMERO.docker.web is required.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a search through this repo, I think that you might mean

"ome.docker role is required."

Yes, this is a dependency of this role, it is in the requirements file. NOT OMERO.docker.web

Copy link
Copy Markdown
Member

@pwalczysko pwalczysko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the OMERO.docker.web is required. line.

@khaledk2 khaledk2 changed the title Remove dependencies Fix dependencies Mar 12, 2026
@khaledk2
Copy link
Copy Markdown
Collaborator Author

Please remove the OMERO.docker.web is required. line.

I have fixed the dependencies by correcting the role name, although I can see the other OME roles don't set the Dependencies section.

README.rst Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Assuming the installation playbook name is ``install_searchengine.yml``

Two backticks are needed for a GitHub rendering of an .rst file:
Tested the suggested fix, see below

Image

Copy link
Copy Markdown
Member

@pwalczysko pwalczysko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

@pwalczysko pwalczysko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@khaledk2 khaledk2 merged commit 27c0785 into ome:master Mar 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants