Skip to content

Fix dependencies #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaledk2 merged 5 commits into from
Mar 14, 2026
Merged

Fix dependencies #17

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba67166
remove_dependencies
khaledk2 Mar 12, 2026
d49d730
use the correct Dependency
khaledk2 Mar 12, 2026
fe14e98
use the correct Dependency
khaledk2 Mar 12, 2026
75c53c4
Fix formatting and typo
khaledk2 Mar 13, 2026
f391037
Fix formatting
khaledk2 Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ Installs and configures the IDR search engine.

Dependencies
------------

OMERO.docker.web is required.

ome.docker is required.

Copy link
Copy Markdown
Member

@pwalczysko pwalczysko Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, imho this still does not make sense. Nobody (including myself) knows what OMERO.docker.web is. And also, I do not believe that it is required.

Please remove the sentence

OMERO.docker.web is required.

Copy link
Copy Markdown
Member

@pwalczysko pwalczysko Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a search through this repo, I think that you might mean

"ome.docker role is required."

Yes, this is a dependency of this role, it is in the requirements file. NOT OMERO.docker.web

Role Variables
--------------
Expand All @@ -33,7 +31,7 @@ Role Variables
- `nginx_port`: The port Nginx should use
- `cache_rows`: The number of rows the indexing process can handle at one time
- `no_index_processes`: The number of parallel processes available for the indexing process
- `dump_output_format`: The data can be dumped in either CSV_BFF or JSON format. default is JSON
- `dump_output_format`: The data can be dumped in either CSV_BFF or JSON format. The default is JSON

Example Playbook
----------------
Expand Down Expand Up @@ -97,7 +95,7 @@ The role can also be used for:

ansible-playbook install_searchengine.yml --tags "dump_projects"

Assuming the installation playbook name is `install_searchengine.yml`
Assuming the installation playbook name is ``install_searchengine.yml``


The user can perform the following checks to ensure that the application is installed correctly and functioning as expected.
Expand Down Expand Up @@ -135,4 +133,3 @@ Author Information
------------------

ome-devel@lists.openmicroscopy.org.uk

Loading