No local version in setuptools_scm - #32
Merged
Merged
Conversation
jo-mueller
added
bug
Automated Review URLs |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the readthedocs build is failing because the build tool (
setuptools_scm) doesn't know how to create a new local version from the git tag. Essentially, when it installs a version (i.e.,0.6.dev1), it tries to create a local version of this like0.6.dev1+098234, which can be helpful to distinguish a local development version from a released version. I'm not sure this is strictly relevant here, so this PR will make stuptools just install stuff with the latest git tag.Tested with a RTD build on this branch, works 👍