Skip to content

Fix PKG_VERSION fix in publish_pypi.yml#684

Merged
jburel merged 2 commits into
ome:masterfrom
will-moore:publish_pypi_syntax_fix
Apr 20, 2026
Merged

Fix PKG_VERSION fix in publish_pypi.yml#684
jburel merged 2 commits into
ome:masterfrom
will-moore:publish_pypi_syntax_fix

Conversation

@will-moore
Copy link
Copy Markdown
Member

This aims to fix the error at https://github.com/ome/omero-figure/actions/runs/24660519372/job/72105014376

Running locally, this works:

$ PKG_VERSION=$(python -c "import omero_figure.utils as u; print(u.__version__)")
$ echo $PKG_VERSION 
8.0.1.rc0

@will-moore
Copy link
Copy Markdown
Member Author

will-moore commented Apr 20, 2026

cc @jburel - seems I trusted the github copilot code here a bit too much.
I think the commit above should fix the syntax error. But I'm also thinking that maybe we don't need that whole build step to compare the version number in figure.utils.py with the github tag? If we stick to the correct bumpversion commands that we've tested then we should be good, so I think we could remove this whole - name: Validate tag matches package version step that was added in #682 ?

@jburel
Copy link
Copy Markdown
Member

jburel commented Apr 20, 2026

Apologies I missed that check.
We do not have that anywhere. We could certainly improve it in a follow up strategy.
Please remove

@will-moore
Copy link
Copy Markdown
Member Author

Done, removed that step from publish_pypi.yml

@jburel jburel merged commit e20c0b5 into ome:master Apr 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants