Skip to content

Fix PKG_VERSION fix in publish_pypi.yml #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jburel merged 2 commits into from
Apr 20, 2026
Merged

Fix PKG_VERSION fix in publish_pypi.yml #684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
850271d
Fix PKG_VERSION fix in publish_pypi.yml
will-moore Apr 20, 2026
f83aee7
Remove 'Validate tag matches package version' step from publish_pypi.yml
will-moore Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions .github/workflows/publish_pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,36 +11,6 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: '3.10'
- name: Validate tag matches package version
if: startsWith(github.ref, 'refs/tags')
run: |
TAG="${GITHUB_REF#refs/tags/}"
# Allow either 1.2.3.rc1 or v1.2.3.rc1 tags.
TAG_NO_V="${TAG#v}"
PKG_VERSION="$(python -c \"import omero_figure.utils as u; print(u.__version__)\")"

echo "Tag: ${TAG}"
echo "Package version: ${PKG_VERSION}"

# Compare normalized PEP 440 versions so 1.2.3.rc1 and 1.2.3rc1 are equivalent.
python - <<'PY'
import os
import sys

from packaging.version import Version

tag = os.environ["TAG_NO_V"]
pkg = os.environ["PKG_VERSION"]
tag_v = Version(tag)
pkg_v = Version(pkg)

if tag_v != pkg_v:
print(f"ERROR: Tag ({tag}) does not match package version ({pkg}).")
print(f"Normalized tag={tag_v}, package={pkg_v}")
sys.exit(1)

print(f"Validated normalized version match: {tag_v}")
PY
- name: Build a binary wheel and a source tarball
run: |
python -mpip install build
Expand Down
Loading