Only add channel to tile request string if active - #541
Merged
will-moore merged 2 commits intoJul 30, 2026
Conversation
will-moore
force-pushed
the
tile_request_active_channels_only
branch
from
July 29, 2026 15:55
e9bbb1a to
865e56b
Compare
Member
Author
|
Temporarily excluding to check that images with many channels fail to render on merge-ci... EDIT: PR was excluded (see above)... |
Member
|
checked on merge-ci, lgtm, thank you |
pwalczysko
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #542
We previously reduced the length of query strings in ome/omero-web#201, but given images with even more channels (148 channel example in issue above), we need to reduce the length further by only including active channels.
To test, import an image (such as the sample image from issue) and check that the URLs for tiles only include active channels.
This has been imported at https://merge-ci.openmicroscopy.org/web/webclient/img_detail/1378/?dataset=871
Without this PR, the image loading fails:
The URL for loading the image tile is
And the response is: