Skip to content

Only add channel to tile request string if active #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
will-moore merged 2 commits into from
Jul 30, 2026
Merged

Only add channel to tile request string if active #541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83cb921
Only add channel to tile request string if active
will-moore Jun 30, 2026
865e56b
Use ch.join(',') to concatenate active channels in query param
will-moore Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 31 additions & 28 deletions src/viewers/viewer/source/Image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,45 +280,48 @@ const OmeroImage = function(options) {

// maps parameter (incl. inverted)
var maps = [];
// add channel param
url += 'c=';
var channels = [];

var channelsLength = this.channels_info_.length;
for (var c=0; c<channelsLength;c++) {
let ch = "";
var channelInfo = this.channels_info_[c];
if (c != 0) url += ',';

// We ONLY include active channels in URL parameters to reduce query length
if (!channelInfo['active']) continue;

// amend url with channel info
url += (!channelInfo['active'] ? "-" : "") + (c + 1);
url += "|" + channelInfo['start'] + ":" + channelInfo['end'];
url += "$" + channelInfo['color']; // color info
ch += (!channelInfo['active'] ? "-" : "") + (c + 1);
ch += "|" + channelInfo['start'] + ":" + channelInfo['end'];
ch += "$" + channelInfo['color']; // color info

var m = {};
if (channelInfo['active']) {
m["inverted"] = { "enabled" :
typeof channelInfo['inverted'] === 'boolean' &&
channelInfo['inverted']
}
m["inverted"] = { "enabled" :
typeof channelInfo['inverted'] === 'boolean' &&
channelInfo['inverted']
}

// Only need to include family if different from default
var family = channelInfo['family'];
var family_not_default = (family !== "linear" ||
(family === "linear" && this.saved_channels_info_[c]["family"] !== "linear"));
if (typeof family === 'string' &&
family !== "" &&
family_not_default &&
typeof channelInfo['coefficient'] === 'number' &&
!isNaN(channelInfo['coefficient'])) {
m["quantization"] = {
"family": family,
};
// Only need coefficient if family is not 'linear' or 'logarithmic'
if (family !== 'linear' && family !== 'logarithmic') {
m["quantization"]["coefficient"] = channelInfo['coefficient'];
}
}
// Only need to include family if different from default
var family = channelInfo['family'];
var family_not_default = (family !== "linear" ||
(family === "linear" && this.saved_channels_info_[c]["family"] !== "linear"));
if (typeof family === 'string' &&
family !== "" &&
family_not_default &&
typeof channelInfo['coefficient'] === 'number' &&
!isNaN(channelInfo['coefficient'])) {
m["quantization"] = {
"family": family,
};
// Only need coefficient if family is not 'linear' or 'logarithmic'
if (family !== 'linear' && family !== 'logarithmic') {
m["quantization"]["coefficient"] = channelInfo['coefficient'];
}
}
channels.push(ch);
maps.push(m);
}
url += "c=" + channels.join(",");
url += "&maps=" + JSON.stringify(maps);
url += '&m=' + this.image_model_;
url += '&p=' + this.image_projection_;
Expand Down
Loading