fix(bill-progress): address remaining review comments after #56#57
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
| Filename | Overview |
|---|---|
| src/tools/bill-progress.ts | Updates Camera timeline hints, pagination ordering, keyword literal escaping, and date filter descriptions. |
| src/tools/tools.test.ts | Updates the Camera empty-result hint expectation. |
| LOG.md | Records the follow-up bill-progress fixes. |
Reviews (2): Last reviewed commit: "fix(bill-progress): letterale SPARQL rob..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Follow-up refinement to bill-progress (MCP tool + CLI) to reduce ambiguity on empty Camera timelines, stabilize pagination ordering for Camera timeline queries, and harden SPARQL keyword escaping—plus aligning tests and changelog accordingly.
Changes:
- Improved Camera-branch empty hint to explicitly call out that filters/pagination can exclude all rows.
- Stabilized Camera timeline pagination ordering by adding a tie-breaker (
ORDER BY ?date ?st) and hardened SPARQL string literal escaping forkeywordviaJSON.stringify. - Updated integration test expectations and added a LOG.md entry documenting the follow-up.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tools/bill-progress.ts | Improves hints, keyword escaping, and Camera timeline query ordering for more deterministic pagination. |
| src/tools/tools.test.ts | Updates expected hint text to match the refined Camera empty-hint messaging. |
| LOG.md | Documents the follow-up changes under the 2026-07-11 entry. |
Review PR #57: - sparqlStringLiteral non usa più JSON.stringify (emette \uXXXX per i controlli, rifiutato da alcuni parser SPARQL): escapa solo \, ", newline, CR come da grammatica STRING_LITERAL2. Verificato: letterale con apice → HTTP 200. - cameraIterTimeline: ?st non è più proiettato in SELECT DISTINCT (cambiava la chiave di dedup → possibili righe visivamente duplicate); resta solo come tie-breaker in ORDER BY. Virtuoso accetta ORDER BY su var non proiettata. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Comment on lines
112
to
+113
| const cameraEmptyHint = | ||
| "Nessuno stato iter Camera trovato per l'atto richiesto. Verifica il pairing legislature+number (o l'URI) e non dedurre assenza di iter dal vuoto: senza evidenza non inventare stati, date o conclusioni."; | ||
| "Nessuno stato iter Camera trovato per l'atto richiesto. Verifica il pairing legislature+number (o l'URI) e, se hai usato keyword/date/limit/offset, prova ad allargare i filtri o la paginazione. Non dedurre assenza di iter dal vuoto: senza evidenza non inventare stati, date o conclusioni."; |
|
|
||
| ## 2026-07-11 | ||
|
|
||
| - **follow-up residuale commenti PR #56 (`bill-progress`)**: migliorato l'hint del ramo Camera su risultato vuoto (ora segnala esplicitamente che `keyword/date/limit/offset` possono escludere tutte le righe), ordinamento timeline Camera reso stabile per paginazione (`ORDER BY ?date ?st`), escape robusto dei literal SPARQL con `JSON.stringify` per `keyword` (Senato + Camera), e descrizioni `dateFrom/dateTo` chiarite sui due significati (presentazione Senato vs data stato-iter Camera). |
aborruso
added a commit
that referenced
this pull request
Jul 11, 2026
fix(bill-progress): hint e LOG — commenti Copilot post-merge #57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the residual high-signal review comments left open after #56.
Changes
keyword/date/limit/offset)ORDER BY ?date ?stkeywordviaJSON.stringify(Senato + Camera paths)dateFrom/dateToschema descriptions for dual semantics (Senato presentation date vs Camera status date)Notes