Holyfuchs/review fixes - #118
Merged
Merged
Conversation
holyfuchs
force-pushed
the
holyfuchs/review-fixes
branch
4 times, most recently
from
August 14, 2026 13:56
6e1c1bb to
d986b55
Compare
holyfuchs
marked this pull request as ready for review
August 14, 2026 14:12
holyfuchs
force-pushed
the
holyfuchs/review-fixes
branch
2 times, most recently
from
August 14, 2026 15:17
59be952 to
a0627d6
Compare
holyfuchs
force-pushed
the
holyfuchs/review-fixes
branch
from
August 14, 2026 19:02
a0627d6 to
3e5ef2b
Compare
tim-barry
approved these changes
Aug 14, 2026
holyfuchs
force-pushed
the
holyfuchs/review-fixes
branch
from
August 15, 2026 03:54
3e5ef2b to
1bba352
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FLOWSCAC-4 (one-share oracle NAV floor): YieldTokenOracle.CONVERSION_SAMPLE was hardcoded to 10**vault.decimals(), maximizing the convertToAssets floor and understating large yield positions; it is now a constructor argument, with DeployVault/Status passing 1e36 so the accumulated error is sub-raw-wei for any realistic TVL.
FLOWSCAC-11 (redeem debt rounding): _unwindSlice rounds debtSlice up (Ceil) and collSlice/yieldOut down (Floor), matching redeemInKind so the residual position is not left under-collateralized.
FLOWSCAC-15 (full delever revert): _rebalanceDelever calls market().repayAll() (repay by borrow shares) when a favorable fill exceeds the remaining debt, instead of repay(currentDebt) (by assets), so a full delever zeros the debt exactly without borrow-share dust that reverts the call.
FLOWSCAC-13 (debt-share dust blocks exits): added test_Fuzz_Redeem_WithDebtDust verifying that after a third-party share repayment leaves debt dust, redeem() recovers via rebalance().
FLOWSCAC-2 (delever strands loan proceeds): documented in _rebalanceDelever that a favorable fill can leave surplus loan token idle in the vault (accepted trade-off).
FLOWSCAC-3 (deposit/redeem MEV slippage): added WARNING NatSpec on deposit() and redeem() in IFCMVault that standard ERC-4626 calls lack slippage protection and should be routed through a router enforcing minSharesOut/minAssetsOut.